[PR #22] [MERGED] Optimize layout to support more themes, add Simplified Chinese #24

Closed
opened 2026-03-04 12:07:04 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/4IceG/luci-app-modemdata/pull/22
Author: @ntbowen
Created: 11/12/2025
Status: Merged
Merged: 11/12/2025
Merged by: @4IceG

Base: mainHead: main


📝 Commits (7)

  • e727a3d Fix checkbox vertical alignment issue across different themes
  • f48d699 Fix ifacebox card layout - make body fill the entire card
  • 3ea77cc Refactor ifacebox styles for better layout
  • d444cce Improve checkbox styling and layout in modem preview
  • 21efa76 Enhance styles for progress bars and modals
  • 5e027d9 Enhance diagnostics page styles and layout
  • fdeb1bf Add files via upload

📊 Changes

3 files changed (+1312 additions, -18 deletions)

View changed files

📝 luci-app-modemdata/htdocs/luci-static/resources/view/modem/modemdiagnostics.js (+325 -16)
📝 luci-app-modemdata/htdocs/luci-static/resources/view/modem/modempreview.js (+92 -2)
luci-app-modemdata/po/zh_Hans/modemdata.po (+895 -0)

📄 Description

work well with multi themes, argon, edge, kucat, alpha are tested.
image
add Simplified Chinese too


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/4IceG/luci-app-modemdata/pull/22 **Author:** [@ntbowen](https://github.com/ntbowen) **Created:** 11/12/2025 **Status:** ✅ Merged **Merged:** 11/12/2025 **Merged by:** [@4IceG](https://github.com/4IceG) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (7) - [`e727a3d`](https://github.com/4IceG/luci-app-modemdata/commit/e727a3dee7ef49c5e5e12f56bc62be30d793b8cd) Fix checkbox vertical alignment issue across different themes - [`f48d699`](https://github.com/4IceG/luci-app-modemdata/commit/f48d699eae86c85c32d36d9d55b26bc48d5a5b56) Fix ifacebox card layout - make body fill the entire card - [`3ea77cc`](https://github.com/4IceG/luci-app-modemdata/commit/3ea77cc3c9d735b3af0bb6a54f8ae21f2d5fab61) Refactor ifacebox styles for better layout - [`d444cce`](https://github.com/4IceG/luci-app-modemdata/commit/d444ccecd68d625f7bb27b8c6b7c48d8e64dd3b6) Improve checkbox styling and layout in modem preview - [`21efa76`](https://github.com/4IceG/luci-app-modemdata/commit/21efa7613a11559d4dde7a8da0d868cd22566e34) Enhance styles for progress bars and modals - [`5e027d9`](https://github.com/4IceG/luci-app-modemdata/commit/5e027d9490d2a97919cf75d1e193b0bc34cd6860) Enhance diagnostics page styles and layout - [`fdeb1bf`](https://github.com/4IceG/luci-app-modemdata/commit/fdeb1bf4bf03eb81afad1cc7bb8c20d59562ce8c) Add files via upload ### 📊 Changes **3 files changed** (+1312 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `luci-app-modemdata/htdocs/luci-static/resources/view/modem/modemdiagnostics.js` (+325 -16) 📝 `luci-app-modemdata/htdocs/luci-static/resources/view/modem/modempreview.js` (+92 -2) ➕ `luci-app-modemdata/po/zh_Hans/modemdata.po` (+895 -0) </details> ### 📄 Description work well with multi themes, argon, edge, kucat, alpha are tested. <img width="3834" height="1820" alt="image" src="https://github.com/user-attachments/assets/0861216d-d21f-40c6-9c3d-91705708c64d" /> add Simplified Chinese too --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem closed this issue 2026-03-04 12:07:05 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/luci-app-modemdata#24
No description provided.