[GH-ISSUE #66] Issues with Argon Theme #50

Open
opened 2026-03-04 11:58:10 +03:00 by kerem · 3 comments
Owner

Originally created by @stich86 on GitHub (Apr 8, 2024).
Original GitHub issue: https://github.com/4IceG/luci-app-3ginfo-lite/issues/66

Hi @4IceG,

i've instellad on my BPI-R3-Mini the Argon Theme, but 3ginfo-lite has some graphical issue like "SIM card" icon not alligned and the text "More information about the 3ginfo on the eko.one.pl forum." that goes out the div when page is resized, here is some example?

how to play with the DIV to align "SIM card" icon and avoid overlap of info text?

image

Enlarge window:

image

Resize window (small horizontal lenght):

image

thanks for any tips :)

Originally created by @stich86 on GitHub (Apr 8, 2024). Original GitHub issue: https://github.com/4IceG/luci-app-3ginfo-lite/issues/66 Hi @4IceG, i've instellad on my BPI-R3-Mini the Argon Theme, but 3ginfo-lite has some graphical issue like "SIM card" icon not alligned and the text "More information about the 3ginfo on the [eko.one.pl forum](https://eko.one.pl/?p=openwrt-3ginfo)." that goes out the div when page is resized, here is some example? how to play with the DIV to align "SIM card" icon and avoid overlap of info text? <img width="891" alt="image" src="https://github.com/4IceG/luci-app-3ginfo-lite/assets/27808541/3c515e6f-bac3-49d2-90a5-11a490cd44f9"> Enlarge window: <img width="1825" alt="image" src="https://github.com/4IceG/luci-app-3ginfo-lite/assets/27808541/a4613f3e-72dd-4509-8de3-88705fc719dd"> Resize window (small horizontal lenght): <img width="787" alt="image" src="https://github.com/4IceG/luci-app-3ginfo-lite/assets/27808541/c06599ad-6203-4e64-91f6-f024ea2a978e"> thanks for any tips :)
Author
Owner

@4IceG commented on GitHub (Apr 8, 2024):

Hi @stich86 , now I know why I don't use third-party themes 😄.

From what I can see, the material theme (Argon works on this theme) has a problem with the ifacebox object, I don't know if it is not described there or if it is there but defined differently (I did not investigate). On the luci-theme-openwrt-2020 theme it looks acceptable.

Unofficial themes are nice as long as they are maintained and supported.

<!-- gh-comment-id:2043333929 --> @4IceG commented on GitHub (Apr 8, 2024): Hi @stich86 , now I know why I don't use third-party themes 😄. From what I can see, the material theme (Argon works on this theme) has a problem with the ifacebox object, I don't know if it is not described there or if it is there but defined differently (I did not investigate). On the luci-theme-openwrt-2020 theme it looks acceptable. Unofficial themes are nice as long as they are maintained and supported.
Author
Owner

@stich86 commented on GitHub (Apr 8, 2024):

I understand..
I'm tweaking a little bit playing with padding, I can get good alignment

Just figure out where to add these mods. In which JS are this page generated? 3gdetail.js?

Thx

<!-- gh-comment-id:2043556960 --> @stich86 commented on GitHub (Apr 8, 2024): I understand.. I'm tweaking a little bit playing with padding, I can get good alignment Just figure out where to add these mods. In which JS are this page generated? 3gdetail.js? Thx
Author
Owner

@4IceG commented on GitHub (Apr 8, 2024):

I know where I set it Link, the question is whether setting it permanently will not ruin the appearance of other themes.

In this case, it would be best to add a css file with the missing description for ifacebox Link. I'm just not sure that it will work with every theme.

Have you tried adding the missing css sections to the Argon theme?

<!-- gh-comment-id:2043594036 --> @4IceG commented on GitHub (Apr 8, 2024): I know where I set it [Link](https://github.com/4IceG/luci-app-3ginfo-lite/blob/46864030221069da10759f074bc2131754bc4991/luci-app-3ginfo-lite/htdocs/luci-static/resources/view/modem/3gdetail.js#L925), the question is whether setting it permanently will not ruin the appearance of other themes. In this case, it would be best to add a css file with the missing description for ifacebox [Link](https://github.com/openwrt/luci/blob/b5763397c4addf349bf8cd665ca8897f583b56b1/themes/luci-theme-openwrt-2020/htdocs/luci-static/openwrt2020/cascade.css#L357). I'm just not sure that it will work with every theme. Have you tried adding the missing css sections to the Argon theme?
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/luci-app-3ginfo-lite#50
No description provided.