starred/luci-app-3ginfo-lite
1
0
Fork 0
mirror of https://github.com/4IceG/luci-app-3ginfo-lite.git synced 2026-04-25 03:16:13 +03:00
Code Issues 59 Projects Releases 5 Packages Wiki Activity

[PR #137] [MERGED] fix: prevent 'undefined length' errors in 3gdetail.js #237

New issue
Closed
opened 2026-03-13 13:54:57 +03:00 by kerem · 0 comments
kerem commented 2026-03-13 13:54:57 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/4IceG/luci-app-3ginfo-lite/pull/137
Author: @iqubik
Created: 3/11/2026
Status: ✅ Merged
Merged: 3/11/2026
Merged by: @4IceG

Base: main ← Head: main

📝 Commits (3)

  • 7b09da5 Update print statement from 'Hello' to 'Goodbye'
  • 1c8dd4c Change greeting from 'Hello' to 'Goodbye'
  • 8d835ea Refactor SIMdata function for safer JSON parsing

📊 Changes

1 file changed (+34 additions, -26 deletions)

View changed files

📝 luci-app-3ginfo-lite/htdocs/luci-static/resources/view/modem/3gdetail.js (+34 -26)

📄 Description

This commit fixes a JS crash (Cannot read properties of undefined - reading 'length') on the main page and during BTS search:

  1. SIMdata: Added safety check sdata.simslot && sdata.simslot.length to prevent crashes when a modem does not return simslot info.
  2. o.onclick: Added check for searchsite existence (to handle uci get failures) and converted properties to Strings before checking length, preventing crashes if Cell ID or MNC/MCC are missing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/4IceG/luci-app-3ginfo-lite/pull/137 **Author:** [@iqubik](https://github.com/iqubik) **Created:** 3/11/2026 **Status:** ✅ Merged **Merged:** 3/11/2026 **Merged by:** [@4IceG](https://github.com/4IceG) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`7b09da5`](https://github.com/4IceG/luci-app-3ginfo-lite/commit/7b09da5df9b2cf6e3c0a14e998130611e916871d) Update print statement from 'Hello' to 'Goodbye' - [`1c8dd4c`](https://github.com/4IceG/luci-app-3ginfo-lite/commit/1c8dd4c11cb051cbedb1afc64838fdc1acaa4790) Change greeting from 'Hello' to 'Goodbye' - [`8d835ea`](https://github.com/4IceG/luci-app-3ginfo-lite/commit/8d835ea216f3175c4eeb5f51a477686edd3aad52) Refactor SIMdata function for safer JSON parsing ### 📊 Changes **1 file changed** (+34 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `luci-app-3ginfo-lite/htdocs/luci-static/resources/view/modem/3gdetail.js` (+34 -26) </details> ### 📄 Description This commit fixes a JS crash (Cannot read properties of undefined - reading 'length') on the main page and during BTS search: 1. `SIMdata`: Added safety check `sdata.simslot && sdata.simslot.length` to prevent crashes when a modem does not return simslot info. 2. `o.onclick`: Added check for `searchsite` existence (to handle uci get failures) and converted properties to Strings before checking length, preventing crashes if Cell ID or MNC/MCC are missing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-13 13:54:57 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.0.77-r20260215
1.0.76-r20250609
1.0.75-r20250505
1.0.74-20240827
1.0.73-20240622
1.0.72-20240519
1.0.71-20240512
1.0.70-20240510
1.0.69-20240427
1.0.68-20240422
1.0.67-20240421
1.0.66-20240421
1.0.65-20240330
1.0.64-20240201
1.0.63-20240127
1.0.62-20240113
1.0.61-20240102
1.0.60-20231204
1.0.59-20231203
1.0.58-20231021
1.0.57-20231008
1.0.56-20230930
1.0.55-20230910
1.0.54-20230903
1.0.53-20230815
1.0.52-20230711
1.0.51-20230710
1.0.50-20230705
1.0.49-20230701
1.0.48-20230629
1.0.47-20230531
1.0.46-20230501
1.0.45-20230410
1.0.44-20230406
1.0.43-20230406
1.0.42-20230404
1.0.41-20230403
1.0.40-20230321
1.0.39-20230321
1.0.38-20230320
1.0.38-20230312
1.0.37-20230223
1.0.36-20230125
1.0.35-20230106
1.0.33-20221207
1.0.32-20221127
1.0.31-20221127
1.0.30-20221021
1.0.29-20221018
1.0.28-20221017
1.0.26-20220930
1.0.25-20220913
1.0.25-20220912
1.0.24-20220910
1.0.23-20220821
1.0.22-20220821
1.0.21-20220817
1.0.20-20220809
1.0.20-20220808
1.0.19-20220806
1.0.19-20220805
1.0.18-20220725
1.0.18-20220720
1.0.18-20220716
1.0.18-20220707
1.0.18-20220706
1.0.17-20220701
1.0.16-20220426
1.0.16-20220422
1.0.16-20220418
1.0.16-20220416
1.0.16-20220415
1.0.15-20220325
1.0.15-20220316
1.0.15-20220315
1.0.14-20220217
1.0.13-20220217
1.0.13-20220216
1.0.12-20220213
1.0.11-20220213
1.0.10-20220212
1.0.10-20220206
1.0.9-20220204
1.0.9-20220113
1.0.9-20220112
1.0.9-20211218
1.0.9-20211213
1.0.8-20211213
1.0.8-20211205
1.0.8-20211204
1.0.8-20211120
1.0.8-2021-10-31
1.0.7-27082021
1.0.7-24082021
1.0.6-22082021
1.0.6-20082021
1.0.6-18082021
1.0.5-16082021
1.0.4-24072021
1.0.4-18072021
1.0.3-14072021
1.0.3-12072021
1.0.3-11072021
1.0.2-09072021
1.0.2-08072021
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/luci-app-3ginfo-lite#237
No description provided.