[PR #90] [MERGED] More comparison fixes #126

New issue

Closed

opened 2026-03-04 11:58:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 11:58:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/4IceG/luci-app-3ginfo-lite/pull/90
Author: @pekmop1024
Created: 8/10/2024
Status: ✅ Merged
Merged: 8/10/2024
Merged by: @4IceG

Base: main ← Head: main

📝 Commits (2)

3db446e more ash comparison fixes
5787d70 Merge branch '4IceG:main' into main

📊 Changes

1 file changed (+8 additions, -8 deletions)

View changed files

📝 luci-app-3ginfo-lite/root/usr/share/3ginfo-lite/3ginfo.sh (+8 -8)

📄 Description

Same as with >, but = now. It should be ==, because = is an assignment operator and so no comparisons happened in that code before fix. And for integers it will be better to user -eq instead of ==.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/4IceG/luci-app-3ginfo-lite/pull/90 **Author:** [@pekmop1024](https://github.com/pekmop1024) **Created:** 8/10/2024 **Status:** ✅ Merged **Merged:** 8/10/2024 **Merged by:** [@4IceG](https://github.com/4IceG) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`3db446e`](https://github.com/4IceG/luci-app-3ginfo-lite/commit/3db446e9d2babea103d12cd157af51c7fd09ae1a) more ash comparison fixes - [`5787d70`](https://github.com/4IceG/luci-app-3ginfo-lite/commit/5787d704e4e5f9cca12bd8fdba6ef39717048ad4) Merge branch '4IceG:main' into main ### 📊 Changes **1 file changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `luci-app-3ginfo-lite/root/usr/share/3ginfo-lite/3ginfo.sh` (+8 -8) </details> ### 📄 Description Same as with `>`, but `=` now. It should be `==`, because `=` is an assignment operator and so no comparisons happened in that code before fix. And for integers it will be better to user `-eq` instead of `==`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>