[PR #118] [MERGED] Fix favorites calls responses #172

New issue

Closed

opened 2026-02-27 19:28:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:28:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lox-audioserver/lox-audioserver/pull/118
Author: @martinsefcik
Created: 1/14/2026
Status: ✅ Merged
Merged: 1/16/2026
Merged by: @rudyberends

Base: 4.x-branch ← Head: fix/favorites-management

📝 Commits (1)

6483c99 fix(favorites): fix favorites calls responses

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 src/modules/loxone/commands/handlers/zoneHandlers.ts (+5 -5)

📄 Description

This PR fixes some errors produced in browser console due to incorrect responses to favorites management calls.

Adding favorite error:

Uncaught (in promise) ZodError: [
  {
    "code": "invalid_type",
    "expected": "number",
    "received": "undefined",
    "path": [
      "roomfavs_add_result",
      "id"
    ],
    "message": "Required"
  },
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "undefined",
    "path": [
      "roomfavs_add_result",
      "name"
    ],
    "message": "Required"
  }
]
    at get error (comps.js?v=16.2.0%20(14749):1:11166815)
    at AppHub.js?v=16.2.0%20(14749):1:306584
    at Set.forEach (<anonymous>)
    at AudioServerDataSource._onMessage (AppHub.js?v=16.2.0%20(14749):1:306544)
    at WebSocket.<anonymous> (AppHub.js?v=16.2.0%20(14749):1:303020)

Favorites reorder error:

comps.js?v=16.2.0%20(14749):1 
 Failed to reorder favorites: ZodError: [
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "array",
    "path": [
      "roomfavs_reorder_result"
    ],
    "message": "Expected string, received array"
  }
]
    at get error (comps.js?v=16.2.0%20(14749):1:11166815)
    at AppHub.js?v=16.2.0%20(14749):1:306584
    at Set.forEach (<anonymous>)
    at AudioServerDataSource._onMessage (AppHub.js?v=16.2.0%20(14749):1:306544)
    at WebSocket.<anonymous> (AppHub.js?v=16.2.0%20(14749):1:303020)

Delete favorite error:

comps.js?v=16.2.0%20(14749):1 
 Uncaught (in promise) ZodError: [
  {
    "code": "invalid_type",
    "expected": "number",
    "received": "undefined",
    "path": [
      "roomfavs_delete_result",
      "delete_id"
    ],
    "message": "Required"
  }
]
    at get error (comps.js?v=16.2.0%20(14749):1:11166815)
    at AppHub.js?v=16.2.0%20(14749):1:306584
    at Set.forEach (<anonymous>)
    at AudioServerDataSource._onMessage (AppHub.js?v=16.2.0%20(14749):1:306544)
    at WebSocket.<anonymous> (AppHub.js?v=16.2.0%20(14749):1:303020)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lox-audioserver/lox-audioserver/pull/118 **Author:** [@martinsefcik](https://github.com/martinsefcik) **Created:** 1/14/2026 **Status:** ✅ Merged **Merged:** 1/16/2026 **Merged by:** [@rudyberends](https://github.com/rudyberends) **Base:** `4.x-branch` ← **Head:** `fix/favorites-management` --- ### 📝 Commits (1) - [`6483c99`](https://github.com/lox-audioserver/lox-audioserver/commit/6483c995eaa19c782ca3450dc3d80e912e07e5c0) fix(favorites): fix favorites calls responses ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/loxone/commands/handlers/zoneHandlers.ts` (+5 -5) </details> ### 📄 Description This PR fixes some errors produced in browser console due to incorrect responses to favorites management calls. Adding favorite error: ``` Uncaught (in promise) ZodError: [ { "code": "invalid_type", "expected": "number", "received": "undefined", "path": [ "roomfavs_add_result", "id" ], "message": "Required" }, { "code": "invalid_type", "expected": "string", "received": "undefined", "path": [ "roomfavs_add_result", "name" ], "message": "Required" } ] at get error (comps.js?v=16.2.0%20(14749):1:11166815) at AppHub.js?v=16.2.0%20(14749):1:306584 at Set.forEach (<anonymous>) at AudioServerDataSource._onMessage (AppHub.js?v=16.2.0%20(14749):1:306544) at WebSocket.<anonymous> (AppHub.js?v=16.2.0%20(14749):1:303020) ``` Favorites reorder error: ``` comps.js?v=16.2.0%20(14749):1 Failed to reorder favorites: ZodError: [ { "code": "invalid_type", "expected": "string", "received": "array", "path": [ "roomfavs_reorder_result" ], "message": "Expected string, received array" } ] at get error (comps.js?v=16.2.0%20(14749):1:11166815) at AppHub.js?v=16.2.0%20(14749):1:306584 at Set.forEach (<anonymous>) at AudioServerDataSource._onMessage (AppHub.js?v=16.2.0%20(14749):1:306544) at WebSocket.<anonymous> (AppHub.js?v=16.2.0%20(14749):1:303020) ``` Delete favorite error: ``` comps.js?v=16.2.0%20(14749):1 Uncaught (in promise) ZodError: [ { "code": "invalid_type", "expected": "number", "received": "undefined", "path": [ "roomfavs_delete_result", "delete_id" ], "message": "Required" } ] at get error (comps.js?v=16.2.0%20(14749):1:11166815) at AppHub.js?v=16.2.0%20(14749):1:306584 at Set.forEach (<anonymous>) at AudioServerDataSource._onMessage (AppHub.js?v=16.2.0%20(14749):1:306544) at WebSocket.<anonymous> (AppHub.js?v=16.2.0%20(14749):1:303020) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>