[PR #76] [MERGED] Preserve original case of maPlayerId parameter #163

New issue

Closed

opened 2026-02-27 19:28:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:28:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lox-audioserver/lox-audioserver/pull/76
Author: @ds556
Created: 11/17/2025
Status: ✅ Merged
Merged: 11/17/2025
Merged by: @rudyberends

Base: fix/update-state-behaviour ← Head: fix/player-id-case

📝 Commits (1)

9d9409d fix(musicassistant): preserve original case of maPlayerId parameter

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/model/adapters/musicAssistant/state/mapper.ts (+3 -3)

📄 Description

It seems the queue_id in MA is case sensitive and we therefore have to preserve the case of the player/queue ID and only convert to lower case when filtering events (object/player ID comparisons).

This fix has been tested locally, though assumes the lower case version is only needed for event filtering. There might be other reasons why it was converted to lower case in the first place.

Fix #70

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lox-audioserver/lox-audioserver/pull/76 **Author:** [@ds556](https://github.com/ds556) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/17/2025 **Merged by:** [@rudyberends](https://github.com/rudyberends) **Base:** `fix/update-state-behaviour` ← **Head:** `fix/player-id-case` --- ### 📝 Commits (1) - [`9d9409d`](https://github.com/lox-audioserver/lox-audioserver/commit/9d9409d643ca8740cd63fad9ba7089e18df4cefc) fix(musicassistant): preserve original case of maPlayerId parameter ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/model/adapters/musicAssistant/state/mapper.ts` (+3 -3) </details> ### 📄 Description It seems the `queue_id` in MA is case sensitive and we therefore have to preserve the case of the player/queue ID and only convert to lower case when filtering events (object/player ID comparisons). This fix has been tested locally, though assumes the lower case version is only needed for event filtering. There might be other reasons why it was converted to lower case in the first place. Fix #70 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>