[PR #170] [CLOSED] bug fix when removing watched file #254

New issue

Closed

opened 2026-02-26 05:31:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:31:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NarrativeScience-old/log.io/pull/170
Author: @thomas-cadeau
Created: 11/9/2015
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (6)

f2f5d24 bug fix on 'TypeError: Cannot read property 'size' of undefined'
718c1fe add return stmt
1db0b4f removing failing test build
59c6b46 start an harvester server for every 'harvester*' found config file
faeb102 change ignore files for git and npm
bf5a991 adding node_modules to npm pack and changing default config location

📊 Changes

12 files changed (+62 additions, -26 deletions)

View changed files

📝 .gitignore (+2 -1)
📝 .npmignore (+5 -0)
📝 Cakefile (+1 -1)
📝 bin/log.io-harvester (+32 -11)
📝 bin/log.io-server (+3 -3)
📝 conf/harvester.conf (+8 -5)
📝 conf/log_server.conf (+1 -1)
📝 conf/web_server.conf (+1 -1)
➕ example/testlogout1.log (+1 -0)
➕ example/testlogout2.log (+1 -0)
➕ example/testlogout3.log (+1 -0)
📝 src/harvester.coffee (+6 -3)

📄 Description

when removing a watched file, the watcher crashes:
/logio/node_modules/log.io/lib/harvester.js:90
_this._readNewLogs(path, stat.size, currSize);
^
TypeError: Cannot read property 'size' of undefined
at /home/logio/node_modules/log.io/lib/harvester.js:90:42
at FSReqWrap.oncomplete (fs.js:95:15)
error: Lost TCP connection...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NarrativeScience-old/log.io/pull/170 **Author:** [@thomas-cadeau](https://github.com/thomas-cadeau) **Created:** 11/9/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`f2f5d24`](https://github.com/NarrativeScience-old/log.io/commit/f2f5d246d9da490dd3148e9e3fa782b550b93366) bug fix on 'TypeError: Cannot read property 'size' of undefined' - [`718c1fe`](https://github.com/NarrativeScience-old/log.io/commit/718c1feaf2a213536e156326d61a1ed16ad2c9f2) add return stmt - [`1db0b4f`](https://github.com/NarrativeScience-old/log.io/commit/1db0b4fac81144c15699dfc7ca49384eca809b28) removing failing test build - [`59c6b46`](https://github.com/NarrativeScience-old/log.io/commit/59c6b46827ee077dddffb8c19cade1129c5dd700) start an harvester server for every 'harvester*' found config file - [`faeb102`](https://github.com/NarrativeScience-old/log.io/commit/faeb102ef6417d42996b4834cf03dad72e2c5968) change ignore files for git and npm - [`bf5a991`](https://github.com/NarrativeScience-old/log.io/commit/bf5a9913016711902d2d2a4b0762d2227d3202b2) adding node_modules to npm pack and changing default config location ### 📊 Changes **12 files changed** (+62 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) 📝 `.npmignore` (+5 -0) 📝 `Cakefile` (+1 -1) 📝 `bin/log.io-harvester` (+32 -11) 📝 `bin/log.io-server` (+3 -3) 📝 `conf/harvester.conf` (+8 -5) 📝 `conf/log_server.conf` (+1 -1) 📝 `conf/web_server.conf` (+1 -1) ➕ `example/testlogout1.log` (+1 -0) ➕ `example/testlogout2.log` (+1 -0) ➕ `example/testlogout3.log` (+1 -0) 📝 `src/harvester.coffee` (+6 -3) </details> ### 📄 Description when removing a watched file, the watcher crashes: /logio/node_modules/log.io/lib/harvester.js:90 _this._readNewLogs(path, stat.size, currSize); ^ TypeError: Cannot read property 'size' of undefined at /home/logio/node_modules/log.io/lib/harvester.js:90:42 at FSReqWrap.oncomplete (fs.js:95:15) error: Lost TCP connection... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>