[PR #71] [CLOSED] Fix and improve server/harvester logging #240

New issue

Closed

opened 2026-02-26 05:31:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:31:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NarrativeScience-old/log.io/pull/71
Author: @parkerd
Created: 5/19/2013
Status: ❌ Closed

Base: master ← Head: logging

📝 Commits (2)

4b43fd5 Fix and improve server/harvester logging
e2d31c3 Fix typo when added new lib

📊 Changes

8 files changed (+33 additions, -26 deletions)

View changed files

📝 bin/log.io-harvester (+0 -7)
📝 bin/log.io-server (+0 -8)
📝 conf/log_server.conf (+2 -1)
📝 conf/web_server.conf (+1 -0)
📝 src/harvester.coffee (+3 -3)
📝 src/server.coffee (+6 -5)
➕ src/util.coffee (+18 -0)
📝 test/functional.coffee (+3 -2)

📄 Description

First, thanks for the great app. Started playing with Log.io yesterday and once I got things running it was excellent. Works very well with our existing Logstash setup to provide a realtime view of events.

It did take me some time to get it going though, which wasn't helped by the logging of Log.io itself being more or less broken (for me at least). I've tried to fix a few things:

Extracted logger to a util file to reduce repetition between server/harvester
Allowed logging to be overridden by the config as it seems was originally intended (this was broken by the scripts in /bin)
Fixed winston's broken default log levels
Added 'log_level' option to the config for cases where don't want to replace the whole logger
Set socket.io to use the same logger as the web server

I'm decent at JS but still learning, and entirely new to Coffee, so if I've made any major mistakes let me know. Have a few other patches I'll submit later for bugs I've hit since getting the logging visible.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NarrativeScience-old/log.io/pull/71 **Author:** [@parkerd](https://github.com/parkerd) **Created:** 5/19/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `logging` --- ### 📝 Commits (2) - [`4b43fd5`](https://github.com/NarrativeScience-old/log.io/commit/4b43fd5edf3c1d82c85edef1528c156ef88da805) Fix and improve server/harvester logging - [`e2d31c3`](https://github.com/NarrativeScience-old/log.io/commit/e2d31c3ebe9a2eea88ad95a29353bfacef6158ef) Fix typo when added new lib ### 📊 Changes **8 files changed** (+33 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `bin/log.io-harvester` (+0 -7) 📝 `bin/log.io-server` (+0 -8) 📝 `conf/log_server.conf` (+2 -1) 📝 `conf/web_server.conf` (+1 -0) 📝 `src/harvester.coffee` (+3 -3) 📝 `src/server.coffee` (+6 -5) ➕ `src/util.coffee` (+18 -0) 📝 `test/functional.coffee` (+3 -2) </details> ### 📄 Description First, thanks for the great app. Started playing with Log.io yesterday and once I got things running it was excellent. Works very well with our existing Logstash setup to provide a realtime view of events. It did take me some time to get it going though, which wasn't helped by the logging of Log.io itself being more or less broken (for me at least). I've tried to fix a few things: - Extracted logger to a util file to reduce repetition between server/harvester - Allowed logging to be overridden by the config as it seems was originally intended (this was broken by the scripts in /bin) - Fixed winston's broken default log levels - Added 'log_level' option to the config for cases where don't want to replace the whole logger - Set socket.io to use the same logger as the web server I'm decent at JS but still learning, and entirely new to Coffee, so if I've made any major mistakes let me know. Have a few other patches I'll submit later for bugs I've hit since getting the logging visible. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>