[PR #73] [CLOSED] Adding existing nodes to existing streams #239

New issue

Closed

opened 2026-02-26 05:31:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:31:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NarrativeScience-old/log.io/pull/73
Author: @parkerd
Created: 5/20/2013
Status: ❌ Closed

Base: master ← Head: pairs

📝 Commits (2)

cfd39f5 Add tests to verify existing nodes aren't added to existing streams
de95e2b Check stream membership when receiving new logs

📊 Changes

2 files changed (+18 additions, -1 deletions)

View changed files

📝 src/server.coffee (+2 -0)
📝 test/functional.coffee (+16 -1)

📄 Description

Ran into a case where an already existing node would not be added to an additional stream when using only +log messages coming over the TCP socket. Added a test case for the TCP socket in general and this specific case, as well as the fix of ensuring the node and stream are paired.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NarrativeScience-old/log.io/pull/73 **Author:** [@parkerd](https://github.com/parkerd) **Created:** 5/20/2013 **Status:** ❌ Closed **Base:** `master` ← **Head:** `pairs` --- ### 📝 Commits (2) - [`cfd39f5`](https://github.com/NarrativeScience-old/log.io/commit/cfd39f5013500235d7601cfa584bb126a4a8f5ec) Add tests to verify existing nodes aren't added to existing streams - [`de95e2b`](https://github.com/NarrativeScience-old/log.io/commit/de95e2b3ae030f677e4f7ebb0e32bdb85796af92) Check stream membership when receiving new logs ### 📊 Changes **2 files changed** (+18 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/server.coffee` (+2 -0) 📝 `test/functional.coffee` (+16 -1) </details> ### 📄 Description Ran into a case where an already existing node would not be added to an additional stream when using only +log messages coming over the TCP socket. Added a test case for the TCP socket in general and this specific case, as well as the fix of ensuring the node and stream are paired. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>