[PR #48] [CLOSED] Fixes issue #47 : Harvester fails to connect if server is not already ru... #236

Closed
opened 2026-02-26 05:31:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NarrativeScience-old/log.io/pull/48
Author: @kosmasgiannis
Created: 12/30/2012
Status: Closed

Base: masterHead: issue_47


📝 Commits (1)

  • 5c40534 Fixes issue #47 : Harvester fails to connect if server is not already running

📊 Changes

1 file changed (+54 additions, -49 deletions)

View changed files

📝 lib/harvester/log_harvester.js (+54 -49)

📄 Description

...nning

It seems that once the socket is initialized, the proper way to "reconnect" is by calling socket.socket.connect()

Based on : http://stackoverflow.com/questions/10437584/socket-io-reconnect/10443120#10443120


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NarrativeScience-old/log.io/pull/48 **Author:** [@kosmasgiannis](https://github.com/kosmasgiannis) **Created:** 12/30/2012 **Status:** ❌ Closed **Base:** `master` ← **Head:** `issue_47` --- ### 📝 Commits (1) - [`5c40534`](https://github.com/NarrativeScience-old/log.io/commit/5c40534118d167cfc14e88faa63be2092f0bc351) Fixes issue #47 : Harvester fails to connect if server is not already running ### 📊 Changes **1 file changed** (+54 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `lib/harvester/log_harvester.js` (+54 -49) </details> ### 📄 Description ...nning It seems that once the socket is initialized, the proper way to "reconnect" is by calling socket.socket.connect() Based on : http://stackoverflow.com/questions/10437584/socket-io-reconnect/10443120#10443120 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 05:31:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/log.io-NarrativeScience-old#236
No description provided.