mirror of
https://github.com/NarrativeScience-old/log.io.git
synced 2026-04-25 09:05:55 +03:00
[PR #46] [CLOSED] Changes to allow filtering by regex #234
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/log.io-NarrativeScience-old#234
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NarrativeScience-old/log.io/pull/46
Author: @nachobayugar
Created: 12/28/2012
Status: ❌ Closed
Base:
master← Head:master📝 Commits (2)
deb2c74changes to allow regex filters722432fchanges to allow filtering by regex - screen_search📊 Changes
6 files changed (+153 additions, -10 deletions)
View changed files
📝
lib/client/css/web_client.css(+39 -1)📝
lib/client/index.html(+3 -0)📝
lib/client/js/history.js(+14 -0)📝
lib/client/js/stream.js(+16 -1)📝
lib/client/js/ui/renderers.jquery.js(+33 -7)📝
lib/client/js/ui/screen_search.jquery.js(+48 -1)📄 Description
Hi!
I've forked the project in order to make some chanhges that I find usefull.
They are just some litle changes. The idea behind them is the following:
Sometimes, in the company I work, whe deploy a new version of any application, and we see logs in order to know if these new version is working fine. In such situations, sometimes, we just want to see only if an Error log is generated. So, to allow seeing only errors logs (or any log matching with any desired regular expression) in a Stream or in a History screen, I've made some changes.
The changes where made only in the client, without modifying any previous behavoiur of log.io.
Specifically, the changes are:
index.html
Line 86:
Line 97:
web_client.css:
From Line 144 to Line 186: Added styles for screen_filter
stream.js:
It was added the filter property when a new Stream is created (this.filter = null)
Lines 56 to 65: add the condition which allows filtering by regex
history.js: Same as stream.js
renderers.jquery.js
Lines 125 to 133: was added a condition to allow filtering logs by regex in stream
Lines 227 to 232: Was added a condition to allow filtering logs by regex in history (similar to the previous lines).
I wish you accept my pull request!!!
Best Regards!!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.