[PR #8] [CLOSED] Added generic installers for the server and harvester #226

Closed
opened 2026-02-26 05:31:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NarrativeScience-old/log.io/pull/8
Author: @aforward
Created: 9/14/2011
Status: Closed

Base: masterHead: master


📝 Commits (10+)

  • be3f356 Fixed hardcoded /usr/local/lib/node_modules to be based on 'which node'
  • 4ad37cf Improved the derivation of NODE_PATH, the existing worked - but was flawed, added the 'dirname' for proper path navigation
  • 94b8e4f Adding server_standalone to avoid the hard coded /usr/local/bin/node issue
  • ed064d7 Added execute permissions ot server_standalone
  • 88102e6 Changed LOG_PATH to LOG_FILENAME and allowing the user to specify the full log file name path
  • 0709251 Updated server standalone to copy 'server' into 'server' and 'client' into 'client' on a mac osx
  • ea4172b Updated run_server to accept a config file as an arugment
  • c2db87e Fixed reference to the BIN_PATH
  • 9079fe1 Changed name from log-server to log.io-server for consistency
  • ba738b4 Removing the log dir creation from the server_standalone

📊 Changes

13 files changed (+90 additions, -22 deletions)

View changed files

.gitignore (+2 -0)
📝 INSTALL.md (+2 -2)
📝 bin/configure (+4 -1)
📝 bin/install/harvester (+1 -1)
bin/install/harvester_standalone (+19 -0)
📝 bin/install/server (+1 -1)
bin/install/server_standalone (+21 -0)
📝 bin/run_harvester (+11 -6)
📝 bin/run_server (+14 -9)
📝 etc/conf/harvester.conf (+7 -0)
📝 etc/conf/server.conf (+6 -0)
📝 etc/init.d/log.io-harvester (+1 -1)
📝 etc/init.d/log.io-server (+1 -1)

📄 Description

Here are the changes that I have made

  1. Aligned the ./bin names with the init.d names (i.e. log-server changed to log.io-server, etc)
  2. Generalized the precondition check using info from "which node"
  3. Added two generalized installers (./install/__standalone) that only installs the application not the init.d scripts
  4. Added a parameter to the ./bin/run__ scripts to accept a configuration file as input
  5. Added log_filename and node_lib to the configuration script

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NarrativeScience-old/log.io/pull/8 **Author:** [@aforward](https://github.com/aforward) **Created:** 9/14/2011 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`be3f356`](https://github.com/NarrativeScience-old/log.io/commit/be3f356e77cc6aa68aec0af813ffaba658777924) Fixed hardcoded /usr/local/lib/node_modules to be based on 'which node' - [`4ad37cf`](https://github.com/NarrativeScience-old/log.io/commit/4ad37cf79c5764260c07dd1b216242c4e0783773) Improved the derivation of NODE_PATH, the existing worked - but was flawed, added the 'dirname' for proper path navigation - [`94b8e4f`](https://github.com/NarrativeScience-old/log.io/commit/94b8e4fd2e62ae7fabd108b7630ef7cbe6a0073a) Adding server_standalone to avoid the hard coded /usr/local/bin/node issue - [`ed064d7`](https://github.com/NarrativeScience-old/log.io/commit/ed064d7154492e344fbcff51e9224e6439fd3bcb) Added execute permissions ot server_standalone - [`88102e6`](https://github.com/NarrativeScience-old/log.io/commit/88102e63dce15c09381965f17a7ba485ed990a23) Changed LOG_PATH to LOG_FILENAME and allowing the user to specify the full log file name path - [`0709251`](https://github.com/NarrativeScience-old/log.io/commit/070925147c91dac61ba789185be1e36d79d03b45) Updated server standalone to copy 'server' into 'server' and 'client' into 'client' on a mac osx - [`ea4172b`](https://github.com/NarrativeScience-old/log.io/commit/ea4172b42b46dc257329e3c9504278471914d11a) Updated run_server to accept a config file as an arugment - [`c2db87e`](https://github.com/NarrativeScience-old/log.io/commit/c2db87e227c4f8ab7b8060f52a19caf9b217e5a5) Fixed reference to the BIN_PATH - [`9079fe1`](https://github.com/NarrativeScience-old/log.io/commit/9079fe1de73ee0183789ae96c7db398fa833a582) Changed name from log-server to log.io-server for consistency - [`ba738b4`](https://github.com/NarrativeScience-old/log.io/commit/ba738b4e7c5aee27270343d2641fdb067afcd075) Removing the log dir creation from the server_standalone ### 📊 Changes **13 files changed** (+90 additions, -22 deletions) <details> <summary>View changed files</summary> ➕ `.gitignore` (+2 -0) 📝 `INSTALL.md` (+2 -2) 📝 `bin/configure` (+4 -1) 📝 `bin/install/harvester` (+1 -1) ➕ `bin/install/harvester_standalone` (+19 -0) 📝 `bin/install/server` (+1 -1) ➕ `bin/install/server_standalone` (+21 -0) 📝 `bin/run_harvester` (+11 -6) 📝 `bin/run_server` (+14 -9) 📝 `etc/conf/harvester.conf` (+7 -0) 📝 `etc/conf/server.conf` (+6 -0) 📝 `etc/init.d/log.io-harvester` (+1 -1) 📝 `etc/init.d/log.io-server` (+1 -1) </details> ### 📄 Description Here are the changes that I have made 1) Aligned the ./bin names with the init.d names (i.e. log-server changed to log.io-server, etc) 2) Generalized the precondition check using info from "which node" 3) Added two generalized installers (./install/__standalone) that only installs the application not the init.d scripts 4) Added a parameter to the ./bin/run__ scripts to accept a configuration file as input 5) Added log_filename and node_lib to the configuration script --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 05:31:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/log.io-NarrativeScience-old#226
No description provided.