[PR #6] [CLOSED] Possible race condition with append() #224

New issue

Closed

opened 2026-02-26 05:31:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:31:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NarrativeScience-old/log.io/pull/6
Author: @ErrorProne
Created: 8/17/2011
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

a6790f6 It seems that some kind of race condition can happen. The append of the group isn't propageted to the DOM-tree when "dom.appendTo("#node_" + this.node.label + " .group2");" is called. So I added the group-dom as additional argument to the log-giles render-function.

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 lib/client/js/ui/renderers.jquery.js (+6 -3)

📄 Description

It seems that some kind of race condition can happen. The append of the group isn't propageted to the DOM-tree when "dom.appendTo("#node_" + this.node.label + " .group2");" is called. So I added the group-dom as additional argument to the log-giles render-function.

This is just a quick hack and not fully tested, but it fixed the problem for me.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NarrativeScience-old/log.io/pull/6 **Author:** [@ErrorProne](https://github.com/ErrorProne) **Created:** 8/17/2011 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`a6790f6`](https://github.com/NarrativeScience-old/log.io/commit/a6790f6193b6066e2e1d61e476b38e7e3df762b7) It seems that some kind of race condition can happen. The append of the group isn't propageted to the DOM-tree when "dom.appendTo("#node_" + this.node.label + " .group2");" is called. So I added the group-dom as additional argument to the log-giles render-function. ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `lib/client/js/ui/renderers.jquery.js` (+6 -3) </details> ### 📄 Description It seems that some kind of race condition can happen. The append of the group isn't propageted to the DOM-tree when "dom.appendTo("#node_" + this.node.label + " .group2");" is called. So I added the group-dom as additional argument to the log-giles render-function. This is just a quick hack and not fully tested, but it fixed the problem for me. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>