[PR #801] [MERGED] server: clean up the attributes, relax the substring filter conditions #960

New issue

Closed

opened 2026-02-27 09:10:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:10:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/801
Author: @nitnelave
Created: 1/17/2024
Status: ✅ Merged
Merged: 1/17/2024
Merged by: @nitnelave

Base: main ← Head: substring

📝 Commits (1)

bc70c31 server: clean up the attributes, relax the substring filter conditions

📊 Changes

7 files changed (+283 additions, -163 deletions)

View changed files

📝 server/src/domain/handler.rs (+1 -0)
📝 server/src/domain/ldap/group.rs (+96 -70)
📝 server/src/domain/ldap/user.rs (+90 -90)
📝 server/src/domain/ldap/utils.rs (+18 -1)
📝 server/src/domain/sql_group_backend_handler.rs (+55 -1)
📝 server/src/infra/graphql/query.rs (+4 -0)
📝 server/src/infra/ldap_handler.rs (+19 -1)

📄 Description

This consolidates both user and group attributes in their map_{user,group}_attribute as the only point of parsing. It adds support for custom attribute filters for groups, and makes a SubString filter on an unknown attribute resolve to just false.

It should help with #739

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/801 **Author:** [@nitnelave](https://github.com/nitnelave) **Created:** 1/17/2024 **Status:** ✅ Merged **Merged:** 1/17/2024 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `substring` --- ### 📝 Commits (1) - [`bc70c31`](https://github.com/lldap/lldap/commit/bc70c31245067053cac772874e02625b46359874) server: clean up the attributes, relax the substring filter conditions ### 📊 Changes **7 files changed** (+283 additions, -163 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/handler.rs` (+1 -0) 📝 `server/src/domain/ldap/group.rs` (+96 -70) 📝 `server/src/domain/ldap/user.rs` (+90 -90) 📝 `server/src/domain/ldap/utils.rs` (+18 -1) 📝 `server/src/domain/sql_group_backend_handler.rs` (+55 -1) 📝 `server/src/infra/graphql/query.rs` (+4 -0) 📝 `server/src/infra/ldap_handler.rs` (+19 -1) </details> ### 📄 Description This consolidates both user and group attributes in their map_{user,group}_attribute as the only point of parsing. It adds support for custom attribute filters for groups, and makes a SubString filter on an unknown attribute resolve to just false. It should help with #739 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>