[PR #758] [MERGED] Fix the Bootstrap script skipping similar named groups #932

New issue

Closed

opened 2026-02-27 09:10:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:10:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/758
Author: @bubylou
Created: 12/11/2023
Status: ✅ Merged
Merged: 12/12/2023
Merged by: @nitnelave

Base: main ← Head: main

📝 Commits (1)

7addfa5 Fix the Bootstrap script skipping similar name groups

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 example_configs/bootstrap/bootstrap.sh (+2 -2)

📄 Description

Existing group checking logic used jq's "contains" which confusingly will do partial string matches. For example a group named "media_admin" will be created then the "media" group will be skipped saying it already exists when it does not. This also occurs for adding groups to users. I noticed this issue when bootstrapping LLDAP on my K3S cluster. Restested the script after my changes and confirm it now works as expected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/758 **Author:** [@bubylou](https://github.com/bubylou) **Created:** 12/11/2023 **Status:** ✅ Merged **Merged:** 12/12/2023 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`7addfa5`](https://github.com/lldap/lldap/commit/7addfa5ce7e2b409940573e17d0972e102a38611) Fix the Bootstrap script skipping similar name groups ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `example_configs/bootstrap/bootstrap.sh` (+2 -2) </details> ### 📄 Description Existing group checking logic used jq's "contains" which confusingly will do partial string matches. For example a group named "media_admin" will be created then the "media" group will be skipped saying it already exists when it does not. This also occurs for adding groups to users. I noticed this issue when bootstrapping LLDAP on my K3S cluster. Restested the script after my changes and confirm it now works as expected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>