[PR #752] [MERGED] app: make it possible to serve lldap behind a sub-path #930

New issue

Closed

opened 2026-02-27 09:10:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:10:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/752
Author: @MinerSebas
Created: 12/5/2023
Status: ✅ Merged
Merged: 12/7/2023
Merged by: @nitnelave

Base: main ← Head: sub-path

📝 Commits (1)

9480c31 app: make it possible to serve lldap behind a sub-path

📊 Changes

6 files changed (+88 additions, -35 deletions)

View changed files

📝 app/index.html (+3 -2)
📝 app/src/components/app.rs (+1 -1)
📝 app/src/infra/api.rs (+29 -17)
📝 app/src/infra/cookies.rs (+3 -2)
📝 server/src/infra/auth_service.rs (+22 -7)
📝 server/src/infra/tcp_server.rs (+30 -6)

📄 Description

This adds support for placing lldap on a sub-path.

To use it, a User needs to set the http_url setting to a URL with a sub-path (http://example.com/lldap) and setup the reverse-proxy to strip the sub-path.
Caddy example:

handle_path /lldap* {
  reverse_proxy http://127.0.0.1:17170
}

Future Work:
Currently, the sub-path is injected every time index.html and main.js are called, but this could be cached instead.
I tried it, but I never used actix before, and thus couldn't make it work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/752 **Author:** [@MinerSebas](https://github.com/MinerSebas) **Created:** 12/5/2023 **Status:** ✅ Merged **Merged:** 12/7/2023 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `sub-path` --- ### 📝 Commits (1) - [`9480c31`](https://github.com/lldap/lldap/commit/9480c3110ca725d4a06039f9dd9d00432931f653) app: make it possible to serve lldap behind a sub-path ### 📊 Changes **6 files changed** (+88 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `app/index.html` (+3 -2) 📝 `app/src/components/app.rs` (+1 -1) 📝 `app/src/infra/api.rs` (+29 -17) 📝 `app/src/infra/cookies.rs` (+3 -2) 📝 `server/src/infra/auth_service.rs` (+22 -7) 📝 `server/src/infra/tcp_server.rs` (+30 -6) </details> ### 📄 Description This adds support for placing lldap on a sub-path. To use it, a User needs to set the `http_url` setting to a URL with a sub-path (`http://example.com/lldap`) and setup the reverse-proxy to strip the sub-path. Caddy example: ``` handle_path /lldap* { reverse_proxy http://127.0.0.1:17170 } ``` Future Work: Currently, the sub-path is injected every time `index.html` and `main.js` are called, but this could be cached instead. I tried it, but I never used actix before, and thus couldn't make it work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>