[PR #610] [CLOSED] enhancement: Emails do not have a message_id #850

Closed
opened 2026-02-27 09:09:58 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/610
Author: @SamantaTarun
Created: 6/22/2023
Status: Closed

Base: mainHead: tarun_samanta/#608


📝 Commits (3)

  • 836626d enhancement: Emails do not have a message_id
  • b5e746a trying to fix error
  • 3903769 fixed some error

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 server/src/infra/mail.rs (+1 -0)

📄 Description

Closes #608

Issue Description:

I noticed that password-reset-mails sent from my system have a higher spam score as expected.
This is because the mails are missing the message-id header.

Usually it is up to the originating client to add this header.
But many email-providers add it automatically if it is missing, because those mails would very likely get flagged as spam and lower their trust score.

Anyway it would be a good thing to not rely on the mailserver to "repair" the mails for us.

I can not implement it myself but here is how another project which is also using lettre solved it.
Maybe someone can get a PR going.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/610 **Author:** [@SamantaTarun](https://github.com/SamantaTarun) **Created:** 6/22/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `tarun_samanta/#608` --- ### 📝 Commits (3) - [`836626d`](https://github.com/lldap/lldap/commit/836626d4977b94b5f2e56e16909a6f3e2188e263) enhancement: Emails do not have a message_id - [`b5e746a`](https://github.com/lldap/lldap/commit/b5e746ab7d217b012b92fba672733c0a59fb8ba2) trying to fix error - [`3903769`](https://github.com/lldap/lldap/commit/39037692dfdffb93b99b2d3799938a6d9883e664) fixed some error ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/src/infra/mail.rs` (+1 -0) </details> ### 📄 Description Closes #608 **Issue Description:** I noticed that password-reset-mails sent from my system have a higher spam score as expected. This is because the mails are missing the message-id header. Usually it is up to the originating client to add this header. But many email-providers add it automatically if it is missing, because those mails would very likely get flagged as spam and lower their trust score. Anyway it would be a good thing to not rely on the mailserver to "repair" the mails for us. I can not implement it myself but here is how another project which is also using lettre solved it. Maybe someone can get a PR going. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 09:09:58 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/lldap-lldap#850
No description provided.