[GH-ISSUE #239] [BUG] No validation on frontend #83

Open
opened 2026-02-27 08:15:08 +03:00 by kerem · 4 comments
Owner

Originally created by @Leopere on GitHub (Jul 12, 2022).
Original GitHub issue: https://github.com/lldap/lldap/issues/239

It would appear that the users name field is able to accept input with spaces and non alpha numeric characters. It seems that when I did this the system seemed to lock up and slow down significantly.

Originally created by @Leopere on GitHub (Jul 12, 2022). Original GitHub issue: https://github.com/lldap/lldap/issues/239 It would appear that the users name field is able to accept input with spaces and non alpha numeric characters. It seems that when I did this the system seemed to lock up and slow down significantly.
Author
Owner

@nitnelave commented on GitHub (Jul 12, 2022):

There's fundamentally no limitation regarding what format usernames take, they're just case insensitive. The problem might be with downstream applications who will not recognize the string as a valid username.
I doubt that it affects performance though, we don't do anything smart with the username apart from lowercasing it.

One other thing to consider is that it's the admins who create users and thus choose the usernames, so I'm counting on them to be a bit reasonable ;)

I might forbid spaces though, just in case.

<!-- gh-comment-id:1182530268 --> @nitnelave commented on GitHub (Jul 12, 2022): There's fundamentally no limitation regarding what format usernames take, they're just case insensitive. The problem might be with downstream applications who will not recognize the string as a valid username. I doubt that it affects performance though, we don't do anything smart with the username apart from lowercasing it. One other thing to consider is that it's the admins who create users and thus choose the usernames, so I'm counting on them to be a bit reasonable ;) I might forbid spaces though, just in case.
Author
Owner

@olaxe commented on GitHub (Jul 18, 2022):

I use emails as User ID because it is much more easy for my users to remember it. Is it possible to keep also authorized all email characters?

<!-- gh-comment-id:1186806975 --> @olaxe commented on GitHub (Jul 18, 2022): I use emails as User ID because it is much more easy for my users to remember it. Is it possible to keep also authorized all email characters?
Author
Owner

@nitnelave commented on GitHub (Jul 18, 2022):

Note that you can configure most services to allow logging in via both email and username, in the LDAP settings

<!-- gh-comment-id:1186820659 --> @nitnelave commented on GitHub (Jul 18, 2022): Note that you can configure most services to allow logging in via both email and username, in the LDAP settings
Author
Owner

@olaxe commented on GitHub (Jul 19, 2022):

Yes thanks. Unfortunately, not the LLDAP reset password process. My users are good at reset their passwords.

<!-- gh-comment-id:1188606793 --> @olaxe commented on GitHub (Jul 19, 2022): Yes thanks. Unfortunately, not the LLDAP reset password process. My users are good at reset their passwords.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/lldap-lldap#83
No description provided.