[PR #479] [MERGED] Update devcontainer and build instructions #768

New issue

Closed

opened 2026-02-27 09:09:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:09:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/479
Author: @pixelrazor
Created: 3/17/2023
Status: ✅ Merged
Merged: 3/20/2023
Merged by: @nitnelave

Base: main ← Head: devcontainer-update

📝 Commits (4)

54da305 Update devcontainer and build instructions
e135684 readd piece
30b19ea update dockerfile
76d8712 Merge branch 'main' into devcontainer-update

📊 Changes

3 files changed (+7 additions, -8 deletions)

View changed files

📝 .devcontainer/Dockerfile (+2 -4)
📝 .devcontainer/devcontainer.json (+4 -1)
📝 README.md (+1 -3)

📄 Description

remove references to node/rollup since we use gzip now.

I tried adding the rust analyzer extension to the devcontainer.json, but there seems to be some issue where it holds the cargo package lock and i can't build lldap. i'll try to add it again in the future if i get it working

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/479 **Author:** [@pixelrazor](https://github.com/pixelrazor) **Created:** 3/17/2023 **Status:** ✅ Merged **Merged:** 3/20/2023 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `devcontainer-update` --- ### 📝 Commits (4) - [`54da305`](https://github.com/lldap/lldap/commit/54da305d9647ffb84f8999c63264b146e4c05b14) Update devcontainer and build instructions - [`e135684`](https://github.com/lldap/lldap/commit/e135684221bf92a34a280bdc71f8b8c456d6ee97) readd piece - [`30b19ea`](https://github.com/lldap/lldap/commit/30b19eace9dffacecc88e945121425b5dc21ef8f) update dockerfile - [`76d8712`](https://github.com/lldap/lldap/commit/76d8712d1c56d11dad5f6f188d4c8a9997d0d976) Merge branch 'main' into devcontainer-update ### 📊 Changes **3 files changed** (+7 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+2 -4) 📝 `.devcontainer/devcontainer.json` (+4 -1) 📝 `README.md` (+1 -3) </details> ### 📄 Description remove references to node/rollup since we use gzip now. I tried adding the rust analyzer extension to the devcontainer.json, but there seems to be some issue where it holds the cargo package lock and i can't build lldap. i'll try to add it again in the future if i get it working --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>