[PR #469] [MERGED] app: get rid of rollup, gzip the wasm #761

Closed
opened 2026-02-27 09:09:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/469
Author: @nitnelave
Created: 3/5/2023
Status: Merged
Merged: 3/5/2023
Merged by: @nitnelave

Base: mainHead: rollup


📝 Commits (1)

  • 397fe7b app: get rid of rollup, gzip the wasm

📊 Changes

9 files changed (+50 additions, -41 deletions)

View changed files

📝 .github/workflows/Dockerfile.dev (+5 -8)
📝 Cargo.toml (+6 -0)
📝 Dockerfile (+1 -2)
📝 app/build.sh (+5 -15)
📝 app/index.html (+1 -1)
📝 app/index_local.html (+1 -1)
📝 app/src/infra/modal.rs (+5 -5)
📝 app/static/main.js (+1 -1)
📝 server/src/infra/tcp_server.rs (+25 -8)

📄 Description

This way we get rid of the npm dependency (it's not needed anyway), and we reduce the file size served (2.6MB -> 700kB)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/469 **Author:** [@nitnelave](https://github.com/nitnelave) **Created:** 3/5/2023 **Status:** ✅ Merged **Merged:** 3/5/2023 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `rollup` --- ### 📝 Commits (1) - [`397fe7b`](https://github.com/lldap/lldap/commit/397fe7b7677c0a8022109ba5e39571c3e375e559) app: get rid of rollup, gzip the wasm ### 📊 Changes **9 files changed** (+50 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/Dockerfile.dev` (+5 -8) 📝 `Cargo.toml` (+6 -0) 📝 `Dockerfile` (+1 -2) 📝 `app/build.sh` (+5 -15) 📝 `app/index.html` (+1 -1) 📝 `app/index_local.html` (+1 -1) 📝 `app/src/infra/modal.rs` (+5 -5) 📝 `app/static/main.js` (+1 -1) 📝 `server/src/infra/tcp_server.rs` (+25 -8) </details> ### 📄 Description This way we get rid of the npm dependency (it's not needed anyway), and we reduce the file size served (2.6MB -> 700kB) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 09:09:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/lldap-lldap#761
No description provided.