[PR #453] [MERGED] Improve reset email errors #753

New issue

Closed

opened 2026-02-27 09:09:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:09:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/453
Author: @nitnelave
Created: 2/15/2023
Status: ✅ Merged
Merged: 2/15/2023
Merged by: @nitnelave

Base: main ← Head: email

📝 Commits (2)

a41d7a3 server: Remove trailing / from the domain URL
837b574 app: improve error message for wrong/expired reset token

📊 Changes

5 files changed (+81 additions, -70 deletions)

View changed files

📝 app/src/components/app.rs (+57 -63)
📝 app/src/components/reset_password_step2.rs (+12 -4)
📝 server/src/infra/auth_service.rs (+6 -2)
📝 server/src/infra/mail.rs (+3 -1)
📝 server/src/infra/tcp_server.rs (+3 -0)

📄 Description

This makes the configuration more robust to a trailing slash in the domain, and improves the error messages when clicking on a non-existing or expired token.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/453 **Author:** [@nitnelave](https://github.com/nitnelave) **Created:** 2/15/2023 **Status:** ✅ Merged **Merged:** 2/15/2023 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `email` --- ### 📝 Commits (2) - [`a41d7a3`](https://github.com/lldap/lldap/commit/a41d7a3bcecbbfad1aba91932ec4a3a7860fead6) server: Remove trailing / from the domain URL - [`837b574`](https://github.com/lldap/lldap/commit/837b57406065beff77fd5ff4b52ded28fe95d490) app: improve error message for wrong/expired reset token ### 📊 Changes **5 files changed** (+81 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `app/src/components/app.rs` (+57 -63) 📝 `app/src/components/reset_password_step2.rs` (+12 -4) 📝 `server/src/infra/auth_service.rs` (+6 -2) 📝 `server/src/infra/mail.rs` (+3 -1) 📝 `server/src/infra/tcp_server.rs` (+3 -0) </details> ### 📄 Description This makes the configuration more robust to a trailing slash in the domain, and improves the error messages when clicking on a non-existing or expired token. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>