[PR #417] [CLOSED] Support LDAP compare #727

New issue

Closed

opened 2026-02-27 09:09:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:09:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/417
Author: @lucat1
Created: 1/12/2023
Status: ❌ Closed

Base: main ← Head: compare

📝 Commits (7)

0f7f826 tests for dn filter in users and groups
24c149a move tests to the ldap_handler level
7d67ce7 initial sketch of the implementation
9b13094 implemented ldap compare
f1781b1 add tests for ldap compare
bb4de05 add tests (one failing)
cc36754 address some PR comments

📊 Changes

3 files changed (+264 additions, -26 deletions)

View changed files

📝 Cargo.lock (+31 -2)
📝 Cargo.toml (+2 -2)
📝 server/src/infra/ldap_handler.rs (+231 -22)

📄 Description

Added support for the ldap compare command. This is a requirement for all services based on django.

You can try the functionality on the default configuration with the following commands:

$ ldapcompare -D "cn=admin,ou=people,dc=example,dc=com" -W -H ldap://localhost:3890 "uid=admin,ou=people,dc=example,dc=com" "uid:admin"
$ ldapcompare -D "cn=admin,ou=people,dc=example,dc=com" -W -H ldap://localhost:3890 "uid=lldap_admin,ou=groups,dc=example,dc=com" "uid:lldap_admin"

Also comparing other fields besides the uid has been tested and appears to be working.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/417 **Author:** [@lucat1](https://github.com/lucat1) **Created:** 1/12/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `compare` --- ### 📝 Commits (7) - [`0f7f826`](https://github.com/lldap/lldap/commit/0f7f826f720751c716065c149fd556f517ab7856) tests for dn filter in users and groups - [`24c149a`](https://github.com/lldap/lldap/commit/24c149a39e264bd5b5326a562bb3ceafb2c6e209) move tests to the ldap_handler level - [`7d67ce7`](https://github.com/lldap/lldap/commit/7d67ce7050c35e349ae95e16d89a04e3ee29426f) initial sketch of the implementation - [`9b13094`](https://github.com/lldap/lldap/commit/9b130947db7526e1b95eba54ae9c34e9639182c1) implemented ldap compare - [`f1781b1`](https://github.com/lldap/lldap/commit/f1781b198d999733640cfc274285dadcfc83c1f8) add tests for ldap compare - [`bb4de05`](https://github.com/lldap/lldap/commit/bb4de05bd8b60a96cb83960203a57a5a2ffbc8b3) add tests (one failing) - [`cc36754`](https://github.com/lldap/lldap/commit/cc36754ba8c7cc1eecddce289696bf5c440f1922) address some PR comments ### 📊 Changes **3 files changed** (+264 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+31 -2) 📝 `Cargo.toml` (+2 -2) 📝 `server/src/infra/ldap_handler.rs` (+231 -22) </details> ### 📄 Description Added support for the ldap compare command. This is a requirement for all services based on django. You can try the functionality on the default configuration with the following commands: ``` $ ldapcompare -D "cn=admin,ou=people,dc=example,dc=com" -W -H ldap://localhost:3890 "uid=admin,ou=people,dc=example,dc=com" "uid:admin" $ ldapcompare -D "cn=admin,ou=people,dc=example,dc=com" -W -H ldap://localhost:3890 "uid=lldap_admin,ou=groups,dc=example,dc=com" "uid:lldap_admin" ``` Also comparing other fields besides the uid has been tested and appears to be working. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>