[PR #391] [CLOSED] [WIP] displayName as struct to faciliate optional display name field. #715

New issue

Closed

opened 2026-02-27 09:09:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:09:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/391
Author: @Moovlin
Created: 12/6/2022
Status: ❌ Closed

Base: main ← Head: displayNameFix

📝 Commits (1)

cef5252 Changed the struct to make things launch. I've done no testing.

📊 Changes

14 files changed (+124 additions, -43 deletions)

View changed files

📝 app/src/components/create_user.rs (+1 -1)
📝 app/src/components/user_details_form.rs (+2 -2)
📝 schema.graphql (+2 -2)
📝 server/src/domain/handler.rs (+4 -3)
📝 server/src/domain/ldap/user.rs (+1 -1)
📝 server/src/domain/model/users.rs (+2 -2)
📝 server/src/domain/sql_backend_handler.rs (+2 -2)
📝 server/src/domain/sql_user_backend_handler.rs (+7 -11)
📝 server/src/domain/types.rs (+78 -2)
📝 server/src/infra/auth_service.rs (+1 -3)
📝 server/src/infra/graphql/mutation.rs (+7 -5)
📝 server/src/infra/graphql/query.rs (+1 -1)
📝 server/src/infra/ldap_handler.rs (+14 -7)
📝 server/src/main.rs (+2 -1)

📄 Description

Opening this as a WIP PR to get a review on the code I've written to make sure it meets the standards of the project as well as get some feedback on the implementation. At this point, i created a new struct which is near identical to the userId struct and then converted all Optional(String)s to DisplayName(String).

Testing:
LLDAP launches and I've run cargo test with one test failing. This may be a test that is failing simply because of the change made or it may require more work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/391 **Author:** [@Moovlin](https://github.com/Moovlin) **Created:** 12/6/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `displayNameFix` --- ### 📝 Commits (1) - [`cef5252`](https://github.com/lldap/lldap/commit/cef5252a606819dfa24f912d40c2356b3eba61e5) Changed the struct to make things launch. I've done no testing. ### 📊 Changes **14 files changed** (+124 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `app/src/components/create_user.rs` (+1 -1) 📝 `app/src/components/user_details_form.rs` (+2 -2) 📝 `schema.graphql` (+2 -2) 📝 `server/src/domain/handler.rs` (+4 -3) 📝 `server/src/domain/ldap/user.rs` (+1 -1) 📝 `server/src/domain/model/users.rs` (+2 -2) 📝 `server/src/domain/sql_backend_handler.rs` (+2 -2) 📝 `server/src/domain/sql_user_backend_handler.rs` (+7 -11) 📝 `server/src/domain/types.rs` (+78 -2) 📝 `server/src/infra/auth_service.rs` (+1 -3) 📝 `server/src/infra/graphql/mutation.rs` (+7 -5) 📝 `server/src/infra/graphql/query.rs` (+1 -1) 📝 `server/src/infra/ldap_handler.rs` (+14 -7) 📝 `server/src/main.rs` (+2 -1) </details> ### 📄 Description Opening this as a WIP PR to get a review on the code I've written to make sure it meets the standards of the project as well as get some feedback on the implementation. At this point, i created a new struct which is near identical to the userId struct and then converted all `Optional(String)`s to `DisplayName(String)`. Testing: LLDAP launches and I've run `cargo test` with one test failing. This may be a test that is failing simply because of the change made or it may require more work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>