[PR #311] [MERGED] Fix download assets js and fonts #670

New issue

Closed

opened 2026-02-27 08:18:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 08:18:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/311
Author: @martadinata666
Created: 10/2/2022
Status: ✅ Merged
Merged: 10/7/2022
Merged by: @nitnelave

Base: main ← Head: main

📝 Commits (10+)

a11e4f4 Ensure it download correctly
418c06b Ensure download path
8d421ae Update Dockerfile.ci.debian
afff244 Update Dockerfile.ci.alpine
d1c5eeb override index.html to index_local.html
0406478 dont overwrite in CI
851429c Add web override, combine check
c918b51 Update Dockerfile.ci.alpine
1e0b4c4 Update Dockerfile.ci.alpine
6ce906a also apply to debian dockerfile

📊 Changes

2 files changed (+6 additions, -2 deletions)

View changed files

📝 .github/workflows/Dockerfile.ci.alpine (+2 -0)
📝 .github/workflows/Dockerfile.ci.debian (+4 -2)

📄 Description

Seems we oversight the download path of js and fonts.

https://github.com/nitnelave/lldap/issues/310

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/311 **Author:** [@martadinata666](https://github.com/martadinata666) **Created:** 10/2/2022 **Status:** ✅ Merged **Merged:** 10/7/2022 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`a11e4f4`](https://github.com/lldap/lldap/commit/a11e4f4084c5f9e9c92ce8e88230e536aed81fcd) Ensure it download correctly - [`418c06b`](https://github.com/lldap/lldap/commit/418c06bb9263636f4fb3db377b3126c28ab1d4b5) Ensure download path - [`8d421ae`](https://github.com/lldap/lldap/commit/8d421ae5d537d555061a809d8cf0b58a7fff7e62) Update Dockerfile.ci.debian - [`afff244`](https://github.com/lldap/lldap/commit/afff244b99c3e9cfc6ad9bc456e19f1992084cee) Update Dockerfile.ci.alpine - [`d1c5eeb`](https://github.com/lldap/lldap/commit/d1c5eeba9e173216a61ef86f5a404af3fb0ddde6) override index.html to index_local.html - [`0406478`](https://github.com/lldap/lldap/commit/040647807f3bf6eb125aa23260bc7ad771d75dbf) dont overwrite in CI - [`851429c`](https://github.com/lldap/lldap/commit/851429cd360c77adf587c6f31cbc3c0ea918231f) Add web override, combine check - [`c918b51`](https://github.com/lldap/lldap/commit/c918b5119fefdf363cb7c6ace88fda4048b3d043) Update Dockerfile.ci.alpine - [`1e0b4c4`](https://github.com/lldap/lldap/commit/1e0b4c413ce3887bcf5a3efb49cd825640b981b9) Update Dockerfile.ci.alpine - [`6ce906a`](https://github.com/lldap/lldap/commit/6ce906ae19081218120b9aae589f19bc813ba728) also apply to debian dockerfile ### 📊 Changes **2 files changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/Dockerfile.ci.alpine` (+2 -0) 📝 `.github/workflows/Dockerfile.ci.debian` (+4 -2) </details> ### 📄 Description Seems we oversight the download path of js and fonts. https://github.com/nitnelave/lldap/issues/310 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>