mirror of
https://github.com/lldap/lldap.git
synced 2026-04-25 08:15:52 +03:00
[PR #89] [MERGED] Add an entrypoint script #537
Labels
No labels
backend
blocked
bug
cleanup
dependencies
docker
documentation
duplicate
enhancement
enhancement
frontend
github_actions
good first issue
help wanted
help wanted
integration
invalid
ldap
pull-request
question
rust
rust
tests
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/lldap-lldap#537
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/lldap/lldap/pull/89
Author: @kaysond
Created: 11/25/2021
Status: ✅ Merged
Merged: 11/25/2021
Merged by: @nitnelave
Base:
main← Head:main📝 Commits (3)
844794dadd an entrypoint script that allows setting secrets from a file; version the upstream containersc0de017move bash install into previous RUN commandac199c2add docs to config template📊 Changes
4 files changed (+31 additions, -4 deletions)
View changed files
📝
Dockerfile(+7 -4)📝
README.md(+2 -0)➕
docker-entrypoint.sh(+18 -0)📝
lldap_config.docker_template.toml(+4 -0)📄 Description
The script allows secrets to be set via env var defined filenames, and preserves the ability to pass different
lldapsubcommands/args via the docker command.Documentation was updated to note the changes.
I took the liberty of pinning the upstream builder and base containers to alpine 3.14 since I noticed
alpine:latestpoints to 3.15 whilerust:alpineuses 3.14. I doubt its causing any issues, but it seems smart to control which versions are used rather than just pointing to latest. Let me know if you have a reason to keep it on latest and I can remove that change.Addresses #84
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.