[PR #89] [MERGED] Add an entrypoint script #537

Closed
opened 2026-02-27 08:17:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/89
Author: @kaysond
Created: 11/25/2021
Status: Merged
Merged: 11/25/2021
Merged by: @nitnelave

Base: mainHead: main


📝 Commits (3)

  • 844794d add an entrypoint script that allows setting secrets from a file; version the upstream containers
  • c0de017 move bash install into previous RUN command
  • ac199c2 add docs to config template

📊 Changes

4 files changed (+31 additions, -4 deletions)

View changed files

📝 Dockerfile (+7 -4)
📝 README.md (+2 -0)
docker-entrypoint.sh (+18 -0)
📝 lldap_config.docker_template.toml (+4 -0)

📄 Description

The script allows secrets to be set via env var defined filenames, and preserves the ability to pass different lldap subcommands/args via the docker command.

Documentation was updated to note the changes.

I took the liberty of pinning the upstream builder and base containers to alpine 3.14 since I noticed alpine:latest points to 3.15 while rust:alpine uses 3.14. I doubt its causing any issues, but it seems smart to control which versions are used rather than just pointing to latest. Let me know if you have a reason to keep it on latest and I can remove that change.

Addresses #84


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/89 **Author:** [@kaysond](https://github.com/kaysond) **Created:** 11/25/2021 **Status:** ✅ Merged **Merged:** 11/25/2021 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`844794d`](https://github.com/lldap/lldap/commit/844794dbacfa2c5da7f71242dedf10e88ae1568e) add an entrypoint script that allows setting secrets from a file; version the upstream containers - [`c0de017`](https://github.com/lldap/lldap/commit/c0de017a66249fdfb1ee7dc30c1bdc2d74bba1b1) move bash install into previous RUN command - [`ac199c2`](https://github.com/lldap/lldap/commit/ac199c2869ef0cea6b6498a3f91ab2c21aea1ccf) add docs to config template ### 📊 Changes **4 files changed** (+31 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+7 -4) 📝 `README.md` (+2 -0) ➕ `docker-entrypoint.sh` (+18 -0) 📝 `lldap_config.docker_template.toml` (+4 -0) </details> ### 📄 Description The script allows secrets to be set via env var defined filenames, and preserves the ability to pass different `lldap` subcommands/args via the docker command. Documentation was updated to note the changes. I took the liberty of pinning the upstream builder and base containers to alpine 3.14 since I noticed `alpine:latest` points to 3.15 while `rust:alpine` uses 3.14. I doubt its causing any issues, but it seems smart to control which versions are used rather than just pointing to latest. Let me know if you have a reason to keep it on latest and I can remove that change. Addresses #84 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 08:17:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/lldap-lldap#537
No description provided.