[PR #75] [MERGED] Implement a CommonComponent to refactor common functionality in app components #528

New issue

Closed

opened 2026-02-27 08:17:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 08:17:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/75
Author: @nitnelave
Created: 10/31/2021
Status: ✅ Merged
Merged: 10/31/2021
Merged by: @nitnelave

Base: main ← Head: common

📝 Commits (10+)

50e91a9 app: Create CommonComponent
f0f6184 app: Migrate change_password to CommonComponent
5d80105 app: Migrate group_details to CommonComponent
c7e0787 app,infra: Move more functionality in CommonComponent
866dc15 app: Migrate user_details to CommonComponent
ed29afc app: Migrate Login to CommonComponent
b197162 app: Migrate AddGroupMember to CommonComponent
1302db7 app: Migrate AddUserToGroup to CommonComponent
79a1f4a app: Migrate CreateGroup to CommonComponent
d9231d4 app: Migrate CreateUser to CommonComponent

📊 Changes

18 files changed (+758 additions, -727 deletions)

View changed files

📝 app/src/components/add_group_member.rs (+49 -65)
📝 app/src/components/add_user_to_group.rs (+49 -65)
📝 app/src/components/change_password.rs (+32 -53)
📝 app/src/components/create_group.rs (+21 -28)
📝 app/src/components/create_user.rs (+40 -47)
📝 app/src/components/delete_group.rs (+55 -46)
📝 app/src/components/delete_user.rs (+55 -46)
📝 app/src/components/group_details.rs (+47 -65)
📝 app/src/components/group_table.rs (+31 -50)
📝 app/src/components/login.rs (+31 -42)
📝 app/src/components/logout.rs (+30 -34)
📝 app/src/components/remove_user_from_group.rs (+33 -45)
📝 app/src/components/user_details.rs (+31 -49)
📝 app/src/components/user_details_form.rs (+44 -46)
📝 app/src/components/user_table.rs (+32 -45)
📝 app/src/infra/api.rs (+2 -1)
➕ app/src/infra/common_component.rs (+175 -0)
📝 app/src/infra/mod.rs (+1 -0)

📄 Description

This makes the implementation more standard, and regularizes the use of error, task, props and so on.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/75 **Author:** [@nitnelave](https://github.com/nitnelave) **Created:** 10/31/2021 **Status:** ✅ Merged **Merged:** 10/31/2021 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `common` --- ### 📝 Commits (10+) - [`50e91a9`](https://github.com/lldap/lldap/commit/50e91a931a5f43a0d04274bc511fc9fad286266c) app: Create CommonComponent - [`f0f6184`](https://github.com/lldap/lldap/commit/f0f618422e8994aec6acee0c5f7de21c02705fdf) app: Migrate change_password to CommonComponent - [`5d80105`](https://github.com/lldap/lldap/commit/5d80105d0015da948bea1cac53c929c6cabf1d85) app: Migrate group_details to CommonComponent - [`c7e0787`](https://github.com/lldap/lldap/commit/c7e07871a71011df4a2543c2958b9a116e61077b) app,infra: Move more functionality in CommonComponent - [`866dc15`](https://github.com/lldap/lldap/commit/866dc15048c1b79fa0d7f97d841f142cd6f75258) app: Migrate user_details to CommonComponent - [`ed29afc`](https://github.com/lldap/lldap/commit/ed29afc8a6446b9a053ec6d067fd7788933c1428) app: Migrate Login to CommonComponent - [`b197162`](https://github.com/lldap/lldap/commit/b1971621d3e10c7faceeb793256c2b00044dfcbc) app: Migrate AddGroupMember to CommonComponent - [`1302db7`](https://github.com/lldap/lldap/commit/1302db7f32e513c863a033180c33f7db2f99dbaa) app: Migrate AddUserToGroup to CommonComponent - [`79a1f4a`](https://github.com/lldap/lldap/commit/79a1f4a4ec300d2871bcab109fa96aecdf81e25d) app: Migrate CreateGroup to CommonComponent - [`d9231d4`](https://github.com/lldap/lldap/commit/d9231d43145a42805c8d178ad65f475ef2c19ce6) app: Migrate CreateUser to CommonComponent ### 📊 Changes **18 files changed** (+758 additions, -727 deletions) <details> <summary>View changed files</summary> 📝 `app/src/components/add_group_member.rs` (+49 -65) 📝 `app/src/components/add_user_to_group.rs` (+49 -65) 📝 `app/src/components/change_password.rs` (+32 -53) 📝 `app/src/components/create_group.rs` (+21 -28) 📝 `app/src/components/create_user.rs` (+40 -47) 📝 `app/src/components/delete_group.rs` (+55 -46) 📝 `app/src/components/delete_user.rs` (+55 -46) 📝 `app/src/components/group_details.rs` (+47 -65) 📝 `app/src/components/group_table.rs` (+31 -50) 📝 `app/src/components/login.rs` (+31 -42) 📝 `app/src/components/logout.rs` (+30 -34) 📝 `app/src/components/remove_user_from_group.rs` (+33 -45) 📝 `app/src/components/user_details.rs` (+31 -49) 📝 `app/src/components/user_details_form.rs` (+44 -46) 📝 `app/src/components/user_table.rs` (+32 -45) 📝 `app/src/infra/api.rs` (+2 -1) ➕ `app/src/infra/common_component.rs` (+175 -0) 📝 `app/src/infra/mod.rs` (+1 -0) </details> ### 📄 Description This makes the implementation more standard, and regularizes the use of `error`, `task`, `props` and so on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>