[PR #31] [MERGED] Graphql cleanup #503

New issue

Closed

opened 2026-02-27 08:17:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 08:17:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/31
Author: @nitnelave
Created: 8/31/2021
Status: ✅ Merged
Merged: 8/31/2021
Merged by: @nitnelave

Base: main ← Head: graphql_cleanup

📝 Commits (10+)

f3a1e0d app: migrate user_details to graphql endpoint
96c93fd graphql: add an endpoint to create a user
f883739 app: make a graphql argument required
351c726 app: fix registration URLs
cd7424e app: migrate user creation to GraphQL
7c24144 model: Inline the BindRequest in the backend
bd97a88 infra: Remove the TCP API
32d21bb api: inline the ListUsersRequest
3e49408 app: Fix local timezone not taken into account
bae643e user_table: refactor to clarify view()

📊 Changes

46 files changed (+520 additions, -670 deletions)

View changed files

📝 .dockerignore (+2 -1)
📝 .github/workflows/rust.yml (+1 -1)
📝 .gitignore (+3 -2)
📝 Cargo.lock (+5 -3)
📝 Cargo.toml (+4 -76)
📝 Dockerfile (+2 -2)
📝 README.md (+9 -9)
📝 app/Cargo.toml (+8 -3)
➕ app/queries/create_user.graphql (+6 -0)
➕ app/queries/get_user_details.graphql (+10 -0)
📝 app/src/api.rs (+3 -24)
📝 app/src/create_user.rs (+37 -20)
📝 app/src/login.rs (+1 -1)
📝 app/src/user_details.rs (+26 -13)
📝 app/src/user_table.rs (+31 -31)
📝 auth/Cargo.toml (+1 -1)
📝 auth/src/lib.rs (+0 -81)
📝 auth/src/opaque.rs (+0 -0)
📝 schema.graphql (+14 -0)
➕ server/Cargo.toml (+75 -0)

...and 26 more files

📄 Description

This PR removes the REST API, leaving just the authentication, LDAP and GrahpQL interfaces.

It also does a bunch of cleanups, and moves the folders around for better architecture.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/31 **Author:** [@nitnelave](https://github.com/nitnelave) **Created:** 8/31/2021 **Status:** ✅ Merged **Merged:** 8/31/2021 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `graphql_cleanup` --- ### 📝 Commits (10+) - [`f3a1e0d`](https://github.com/lldap/lldap/commit/f3a1e0d84e0132924a9abff880e97f5292e4ce6e) app: migrate user_details to graphql endpoint - [`96c93fd`](https://github.com/lldap/lldap/commit/96c93fd3c1e5c75f5d5d0abd641dbf5f174b7ba7) graphql: add an endpoint to create a user - [`f883739`](https://github.com/lldap/lldap/commit/f88373968e187ee101a111fda99f1be9688c0671) app: make a graphql argument required - [`351c726`](https://github.com/lldap/lldap/commit/351c7267d32d46e096ecff5b4253e2915596930d) app: fix registration URLs - [`cd7424e`](https://github.com/lldap/lldap/commit/cd7424e2c7375ee646a76989c818a8f7f84ceb18) app: migrate user creation to GraphQL - [`7c24144`](https://github.com/lldap/lldap/commit/7c24144b74d473637802a76c7046b595adf07d41) model: Inline the BindRequest in the backend - [`bd97a88`](https://github.com/lldap/lldap/commit/bd97a88d2ba5aa77c165cfe868ffecd31b6b2d8c) infra: Remove the TCP API - [`32d21bb`](https://github.com/lldap/lldap/commit/32d21bb1a83e6a102669d15194dd7ca9eefc3bb4) api: inline the ListUsersRequest - [`3e49408`](https://github.com/lldap/lldap/commit/3e49408006816bddb78f89b3e41aa576d0a4b644) app: Fix local timezone not taken into account - [`bae643e`](https://github.com/lldap/lldap/commit/bae643e1b2f45dccd8b3e3e0c5bd4f7c3667fe6b) user_table: refactor to clarify view() ### 📊 Changes **46 files changed** (+520 additions, -670 deletions) <details> <summary>View changed files</summary> 📝 `.dockerignore` (+2 -1) 📝 `.github/workflows/rust.yml` (+1 -1) 📝 `.gitignore` (+3 -2) 📝 `Cargo.lock` (+5 -3) 📝 `Cargo.toml` (+4 -76) 📝 `Dockerfile` (+2 -2) 📝 `README.md` (+9 -9) 📝 `app/Cargo.toml` (+8 -3) ➕ `app/queries/create_user.graphql` (+6 -0) ➕ `app/queries/get_user_details.graphql` (+10 -0) 📝 `app/src/api.rs` (+3 -24) 📝 `app/src/create_user.rs` (+37 -20) 📝 `app/src/login.rs` (+1 -1) 📝 `app/src/user_details.rs` (+26 -13) 📝 `app/src/user_table.rs` (+31 -31) 📝 `auth/Cargo.toml` (+1 -1) 📝 `auth/src/lib.rs` (+0 -81) 📝 `auth/src/opaque.rs` (+0 -0) 📝 `schema.graphql` (+14 -0) ➕ `server/Cargo.toml` (+75 -0) _...and 26 more files_ </details> ### 📄 Description This PR removes the REST API, leaving just the authentication, LDAP and GrahpQL interfaces. It also does a bunch of cleanups, and moves the folders around for better architecture. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>