mirror of
https://github.com/lldap/lldap.git
synced 2026-04-25 00:05:50 +03:00
[GH-ISSUE #1399] [FEATURE REQUEST] Change Avatar Data Type to MEDIUMBLOB? #487
Labels
No labels
backend
blocked
bug
cleanup
dependencies
docker
documentation
duplicate
enhancement
enhancement
frontend
github_actions
good first issue
help wanted
help wanted
integration
invalid
ldap
pull-request
question
rust
rust
tests
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/lldap-lldap#487
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @wuast94 on GitHub (Feb 19, 2026).
Original GitHub issue: https://github.com/lldap/lldap/issues/1399
Motivation
At the moment the data type for Avatar is BLOB which in mariadb only supports 64K size which is quite small for a Picture.
Describe the solution you'd like
If changing it to MEDIUMBLOB it would accept 16M which should be a sweetspot of not to large and not to small.
Describe alternatives you've considered
using tools to compress images so much is hard, and not really practical for non tech users.
Additional context
I found
github.com/lldap/lldap@aa1384939b/crates/sql-backend-handler/src/sql_tables.rs (L198)But i didn’t understand exactly how Postgres, SQLite, Mariadb and MySQL are implemented, as far as i know postgres dont have BLOB as data type at all, so i dont know how huge this change would be, at least for Mariadb (and maybee MySQL?) it should be a simple migration?
AND thanks for this great work
@eyJhb commented on GitHub (Feb 19, 2026):
I'm not really sure how easy it is to change, based on this https://docs.rs/sea-query/0.32.7/src/sea_query/table/column.rs.html#18-59 .
But it was once migrated from binary to blob, ie. here
github.com/lldap/lldap@aa1384939b/crates/sql-backend-handler/src/sql_migrations.rs (L503-L510)So... Maybe VarBinary would make sense?