mirror of
https://github.com/lldap/lldap.git
synced 2026-04-25 08:15:52 +03:00
[GH-ISSUE #1206] [BUG] lldap_set_password doesn't respect system certificates #428
Labels
No labels
backend
blocked
bug
cleanup
dependencies
docker
documentation
duplicate
enhancement
enhancement
frontend
github_actions
good first issue
help wanted
help wanted
integration
invalid
ldap
pull-request
question
rust
rust
tests
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/lldap-lldap#428
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BerkhanBerkdemir on GitHub (Jul 8, 2025).
Original GitHub issue: https://github.com/lldap/lldap/issues/1206
Originally assigned to: @Copilot on GitHub.
The
lldap_set_passwordbinary does not respect system certificates entirely.Because of that, if the user brings their own CA or self-signed certificate, they won't able to use
lldap_set_password, and thus, theirbootstrap.shwill fail during user password update.This bug report can be reproduced by
docker.io/lldap/lldap:stableordocker.io/lldap/lldap:2025-07-06container.To Reproduce
Steps to reproduce the behavior:
Expected behavior
lldap_set_passwordwould have read system certificates or provide a flag/environment variable to point which certificates to read.Since the mentioned binary doesn't have verbose mode, only the posted error is available.
@nitnelave commented on GitHub (Jul 8, 2025):
It looks like we just need to add the "rustls-tls-native-roots-no-provider" feature to the crate. In set-password/Cargo.toml, add it to the features of reqwest.
@nitnelave commented on GitHub (Jul 8, 2025):
You can give it a try and tell me if it works for you. @BerkhanBerkdemir
@BerkhanBerkdemir commented on GitHub (Jul 9, 2025):
Hey @nitnelave! Thanks for the quick patch. I wasn't expecting this to be that simple even though I knew it has something to do with upstream. I am looking in the CI pipeline, but I am not seeing any artifacts that is generated.
https://github.com/lldap/lldap/actions/runs/16154001242/job/45592430171
This CI job failed because of 503? Though, I tried it putting the binary into a container like below
@nitnelave commented on GitHub (Jul 9, 2025):
There should be a nightly docker build generated within 24h that you can pick up.
That said, I haven't actually tested that it fixed anything :D
@BerkhanBerkdemir commented on GitHub (Jul 9, 2025):
Apparently, Docker Hub doesn't have any updated containers since July 6 and as well as last push.
@BerkhanBerkdemir commented on GitHub (Jul 9, 2025):
This output is from
bootstrap.shI guess last thing I will try is to change something in my CA chain.
@nitnelave commented on GitHub (Jul 10, 2025):
The pipeline that's supposed to produce the docker image keeps failing. I'll try again, but it's not LLDAP, it's GH actions the problem.
@BerkhanBerkdemir commented on GitHub (Jul 10, 2025):
Apparently I was using self-signed certificate but not my CA. Now, I added my CA, and I am still getting the following error from
docker.io/lldap/lldap:2025-07-06.However, good news. With
docker.io/lldap/lldap:2025-07-10, the problem has been solved. If I omit the CA chain of mine,bootstrap.shwould stuck on 'waiting lldap' because of quiet curl fails to verify the authenticity of the certificate.One-liner below would help others in the future, I believe.
@nitnelave commented on GitHub (Jul 10, 2025):
So the fix worked? Woohoo!
@BerkhanBerkdemir commented on GitHub (Jul 11, 2025):
It worked, and I am perfecting GitOps part of the project. I've followed some of the documentation, but I am seeing possible improvements. I hope that those improvements are not my architecture specific. This bug report now can be closed :)