mirror of
https://github.com/lldap/lldap.git
synced 2026-04-26 00:36:01 +03:00
[GH-ISSUE #1176] [FEATURE REQUEST] Enable providing storage password as secret #421
Labels
No labels
backend
blocked
bug
cleanup
dependencies
docker
documentation
duplicate
enhancement
enhancement
frontend
github_actions
good first issue
help wanted
help wanted
integration
invalid
ldap
pull-request
question
rust
rust
tests
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/lldap-lldap#421
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jochemvangrondelle on GitHub (May 17, 2025).
Original GitHub issue: https://github.com/lldap/lldap/issues/1176
Motivation
Unless I'm mistaken, currently the postgres password (if used) has to be provided through the LLDAP_DATABASE_URL environment variable. This is less secure than storing the secret as file.
Describe the solution you'd like
Could mimic similar behaviour from other Dockers (https://hub.docker.com/_/postgres) or the existing behaviour like LLDAP_JWT_SECRET_FILE
Add new optional environment variables LLDAP_DATABASE_PASSWORD and LLDAP_DATABASE_PASSWORD_FILE. If _FILE is there it will populate the LLDAP_DATABASE_PASSWORD var. If LLDAP_DATABASE_PASSWORD is set, use that for authentication with the DB OR enable the env to be used inside the connection string, e.g. LLDAP_DATABASE_URL="postgres://lldap:${LLDAP_DATABASE_PASSWORD}@lldap/lldap"
Describe alternatives you've considered
For now, I'm using the approach with the DB secret in lldap.env that is included in the docker-compose env_file.
Additional context
Thank for you considering my request. Apologies if I have overlooked anything and this feature already exists.
@nitnelave commented on GitHub (May 17, 2025):
You can use
LLDAP_DATABASE_URL_FILE, does that solve your problem?