mirror of
https://github.com/lldap/lldap.git
synced 2026-04-25 00:05:50 +03:00
[GH-ISSUE #88] PKG files not being loaded? #39
Labels
No labels
backend
blocked
bug
cleanup
dependencies
docker
documentation
duplicate
enhancement
enhancement
frontend
github_actions
good first issue
help wanted
help wanted
integration
invalid
ldap
pull-request
question
rust
rust
tests
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/lldap-lldap#39
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JaneJeon on GitHub (Nov 25, 2021).
Original GitHub issue: https://github.com/lldap/lldap/issues/88
Hey, I'm really sorry about filing all these issues but it's just what I've been encountering as I've been trying to set it up myself...
After I've finally set up the server (after dealing with the permissions issues), I load up the server at 17170 and... nothing. Just a blank screen.
On further inspection, it seems that GET call to
/pkg/bundle.jswas returning 404. Fair enough.I checked the
/appdirectory, and there it is -/app/app/bundle.js.I was checking the code for why it might 404, and I think this is the issue:
github.com/nitnelave/lldap@edf9e538ce/server/src/infra/tcp_server.rs (L78)Specifically, when you bundle all the stuff together with rollup, you place it within
/app/app/pkg/bundle.js, and within the Dockerfile, you copy it onto the/app/app/bundle.js: https://github.com/nitnelave/lldap/blob/main/Dockerfile#L60I'm guessing when you last used/tested the frontend, it was pre-packaging the files during Docker build steps (i.e. the endpoint was serving
./pkg/bundle.jsjust fine because thepkgdirectory was there), but because the server looks for the hardcoded./pkg/*directory, it cannot find the bundle (and everything else that was packaged) when you run the Docker container.I highly suspect that this is the case. Could you put out a fix if it is? It's preventing anyone from actually using the frontend. Thanks
@nitnelave commented on GitHub (Nov 25, 2021):
Thanks for the debug! That issue came from the latest dockerfile, and the "COPY" not doing what I expected (it flattened the directory). I'm pushing a fix in #90 .
@JaneJeon commented on GitHub (Nov 25, 2021):
nice, thanks for the quick fix and happy thanksgivign!
@JaneJeon commented on GitHub (Nov 25, 2021):
*thanksgiving