mirror of
https://github.com/lldap/lldap.git
synced 2026-04-26 00:36:01 +03:00
[GH-ISSUE #849] [BUG] Uppercase names not searchable #306
Labels
No labels
backend
blocked
bug
cleanup
dependencies
docker
documentation
duplicate
enhancement
enhancement
frontend
github_actions
good first issue
help wanted
help wanted
integration
invalid
ldap
pull-request
question
rust
rust
tests
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/lldap-lldap#306
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @adyanth on GitHub (Feb 24, 2024).
Original GitHub issue: https://github.com/lldap/lldap/issues/849
Describe the bug
Groups (or even names possibly?) are case sensitive when LDAP isn't.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expect comparisons to follow LDAP naming and check in lower case.
Logs
Working group logs
Group Name:
jellyfin_usersNon working group logs
Group Name:
JellyfinUsersAdditional context
Using Jellyfin LDAP plugin to test.
Possible source of the issue here?
github.com/lldap/lldap@959bb907d8/server/src/domain/sql_user_backend_handler.rs (L101)@adyanth commented on GitHub (Feb 24, 2024):
Also LLDAP allows me to create duplicate groups? I can create two groups with the exact same name. That looks like it shouldn't be possible, because if it has different members, searches will be a union of the two.
@nitnelave commented on GitHub (Feb 25, 2024):
All of that should be fixed in latest, have you tried?
@adyanth commented on GitHub (Feb 25, 2024):
I installed from the LLDAP OBS package, which seems to match the latest release. Do you mean compiling the main branch myself?
@nitnelave commented on GitHub (Feb 25, 2024):
That's the latest stable release, but not the latest beta, e.g. the docker image tagged "latest".
We're working towards a stable release, but the web UI is not quite there yet.
(Note that there's nothing unstable about latest, there's just only partial support of custom attributes in the web UI)
@adyanth commented on GitHub (Feb 25, 2024):
I see. I am not using docker for lldap, I will compile main tomorrow and report back on how it goes. Thanks!
@adyanth commented on GitHub (Feb 25, 2024):
Does not work on 0.5.1-alpha either (Compiled commit
959bb90)I made a group
JellyfinUsers, added a test user. When filtering for JellyfinUsers from Jellyfin, I get 0 users. I make another groupjellyfinusers, and that is detected without changing the filter.Also, I am able to add duplicate group names.
My user and admin filter is set to
(memberof=cn=JellyfinUsers,ou=groups,dc=example,dc=com).Logs with only JellyfinUsers (containing user test in LLDAP
Logs with both JellyfinUsers (user test) and jellyfinusers (user test2) in LLDAP:
@nitnelave commented on GitHub (Feb 26, 2024):
So, the fix I mentioned was indeed intended to fix that issue, but it was half-botched and ended up introducing more issues... I finished it properly. You might want to delete your groups with duplicate names before upgrading or you'll get a hard startup error.