starred/lldap-lldap

Fork 0

mirror of https://github.com/lldap/lldap.git synced 2026-04-25 08:15:52 +03:00

[GH-ISSUE #527] Also provide alternate image registry to `ghcr`? #193

New issue

Closed

opened 2026-02-27 08:15:48 +03:00 by kerem · 5 comments

kerem commented

2026-02-27 08:15:48 +03:00

Owner

Originally created by @budimanjojo on GitHub (Apr 5, 2023).
Original GitHub issue: https://github.com/lldap/lldap/issues/527

Hello! Thanks for this amazing project!

Dockerhub's rate limits (100/6hours pull actions) is frustrating to deal with when you have a lot of containers. It would be great to also host the images on ghcr or maybe quay.io. The implementation should also be pretty easy looking at the current workflow that push the images. I believe it's as simple as adding these lines to this file: https://github.com/lldap/lldap/blob/main/.github/workflows/docker-build-static.yml

Below this: github.com/lldap/lldap@86b2b5148d/.github/workflows/docker-build-static.yml (L469-L474) add:

      - name: Login to GitHub Container Registry
        if: github.event_name != 'pull_request'
        uses: docker/login-action@v2
        with:
          username: ${{ github.repository_owner }}
          password: ${{ secrets.GITHUB_TOKEN }}

And in every line like this: github.com/lldap/lldap@86b2b5148d/.github/workflows/docker-build-static.yml (L487)

change them to something like this:

          tags: |
            nitnelave/lldap:latest, nitnelave/lldap:latest-alpine
            ghcr.io/lldap/lldap:latest, ghcr.io/lldap/lldap:latest-alpine

I can do a PR if you don't have time to do this. Thanks before.

Originally created by @budimanjojo on GitHub (Apr 5, 2023). Original GitHub issue: https://github.com/lldap/lldap/issues/527 Hello! Thanks for this amazing project! Dockerhub's rate limits (100/6hours pull actions) is frustrating to deal with when you have a lot of containers. It would be great to also host the images on `ghcr` or maybe `quay.io`. The implementation should also be pretty easy looking at the current workflow that push the images. I believe it's as simple as adding these lines to this file: https://github.com/lldap/lldap/blob/main/.github/workflows/docker-build-static.yml Below this: https://github.com/lldap/lldap/blob/86b2b5148d107883b1dc0fd004c7ca2a8c8d653e/.github/workflows/docker-build-static.yml#L469-L474 add: ``` - name: Login to GitHub Container Registry if: github.event_name != 'pull_request' uses: docker/login-action@v2 with: username: ${{ github.repository_owner }} password: ${{ secrets.GITHUB_TOKEN }} ``` And in every line like this: https://github.com/lldap/lldap/blob/86b2b5148d107883b1dc0fd004c7ca2a8c8d653e/.github/workflows/docker-build-static.yml#L487 change them to something like this: ``` tags: | nitnelave/lldap:latest, nitnelave/lldap:latest-alpine ghcr.io/lldap/lldap:latest, ghcr.io/lldap/lldap:latest-alpine ``` I can do a PR if you don't have time to do this. Thanks before.

kerem closed this issue

2026-02-27 08:15:48 +03:00

kerem commented

2026-02-27 08:15:49 +03:00

Author

Owner

@budimanjojo commented on GitHub (Apr 5, 2023):

Just realize there's already a PR for this: https://github.com/lldap/lldap/pull/470

Maybe I can help with the I think we should rather incorporate this into the other docker workflow, so we don't have to repeat the work. In addition, it'll support the various architectures that we do. comment there.

@budimanjojo commented on GitHub (Apr 5, 2023): Just realize there's already a PR for this: https://github.com/lldap/lldap/pull/470 Maybe I can help with the `I think we should rather incorporate this into the other docker workflow, so we don't have to repeat the work. In addition, it'll support the various architectures that we do.` comment there.

kerem commented

2026-02-27 08:15:49 +03:00

Author

Owner

@nitnelave commented on GitHub (Apr 5, 2023):

Feel free to take over the PR or create a new one, I think it was abandoned by the author.

Also, I don't know how much that changes, but keep in mind that I'd like to migrate to push to both nitnelave/lldap and lldap/lldap.

@nitnelave commented on GitHub (Apr 5, 2023): Feel free to take over the PR or create a new one, I think it was abandoned by the author. Also, I don't know how much that changes, but keep in mind that I'd like to migrate to push to both nitnelave/lldap and lldap/lldap.

kerem commented

2026-02-27 08:15:49 +03:00

Author

Owner

@budimanjojo commented on GitHub (Apr 5, 2023):

Thanks! I can do the PR, but to be able to push to nitnelave/lldap you might need to setup a GH secret for that username, maybe I can create PR to push to ghcr.io/lldap/lldap and you can change that to ghcr.io/nitnelave/lldap by yourself by changing the login username and password workflow step later?

@budimanjojo commented on GitHub (Apr 5, 2023): Thanks! I can do the PR, but to be able to push to `nitnelave/lldap` you might need to setup a GH secret for that username, maybe I can create PR to push to `ghcr.io/lldap/lldap` and you can change that to `ghcr.io/nitnelave/lldap` by yourself by changing the login username and password workflow step later?

kerem commented

2026-02-27 08:15:49 +03:00

Author

Owner

@nitnelave commented on GitHub (Apr 5, 2023):

Yeah, I can take care of setting up any secret that's needed. Just highlight them in the PR.

@nitnelave commented on GitHub (Apr 5, 2023): Yeah, I can take care of setting up any secret that's needed. Just highlight them in the PR.

kerem commented

2026-02-27 08:15:49 +03:00

Author

Owner

@budimanjojo commented on GitHub (Apr 5, 2023):

I created the PR. Can u have a look? Thanks before.

@budimanjojo commented on GitHub (Apr 5, 2023): I created the PR. Can u have a look? Thanks before.

kerem referenced this issue

2026-02-27 08:18:09 +03:00

[PR #193] [MERGED] Add filter by group #603