mirror of
https://github.com/lldap/lldap.git
synced 2026-04-25 08:15:52 +03:00
[GH-ISSUE #431] SMTP ENABLE_PASSWORD_RESET #163
Labels
No labels
backend
blocked
bug
cleanup
dependencies
docker
documentation
duplicate
enhancement
enhancement
frontend
github_actions
good first issue
help wanted
help wanted
integration
invalid
ldap
pull-request
question
rust
rust
tests
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/lldap-lldap#163
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @zer0ish on GitHub (Feb 1, 2023).
Original GitHub issue: https://github.com/lldap/lldap/issues/431
I just changed my settings so that I can modify the SMTP info using the variable option in Unraid docker container instead of going to the config file.
I re-commented them in the config.
Set the variables in the container.
I wanted to test this variable to see if it works and noticed that if this one is set to False, the reset link still goes through.
Container Variable: LLDAP_SMTP_OPTIONS__ENABLE_PASSWORD_RESET
Shouldn't this either remove the reset option from the GUI or have a error message and not send a reset link?
Also, is it needed to have the double underscores for these? The config file shows the example with double underscore. But wanted to make sure it wasn't a typo.
@nitnelave commented on GitHub (Feb 1, 2023):
Hmm, it seems we don't actually use that config value anywhere. We should probably add an endpoint on the server to check whether it's supported (like
/server_inforeturning{password_reset_supported: true}), check that on page load in the client and change the UI in case it's not supported.Good callout!
It shouldn't be too hard, if someone wants to pick this up.