starred/lldap-lldap

Fork 0

mirror of https://github.com/lldap/lldap.git synced 2026-04-25 08:15:52 +03:00

[GH-ISSUE #408] Missing assets in the release binaries #157

New issue

Closed

opened 2026-02-27 08:15:35 +03:00 by kerem · 8 comments

kerem commented

2026-02-27 08:15:35 +03:00

Owner

Originally created by @lucat1 on GitHub (Jan 5, 2023).
Original GitHub issue: https://github.com/lldap/lldap/issues/408

Hi, lovely project. I've been trying to set it up from the release artifacts provided on github.
I had to do a mkdir app && mv bundle.js index.html pkg app which is not really well documented.
Besides this I noticed the style.css file is missing in the release tarball.
It would be amazing if the files were made available in the releases (so I don't have to compile the thing myself) and already provided in the correct file structure. I can help with automating such a process with Github Actions if you're interested.

Lastly, loading the webpage doesn't work because all of bootstrap assets have a mismatched sha384. I don't really think this is an issue on your side, but I just wanted to point it out.

Originally created by @lucat1 on GitHub (Jan 5, 2023). Original GitHub issue: https://github.com/lldap/lldap/issues/408 Hi, lovely project. I've been trying to set it up from the release artifacts provided on github. I had to do a `mkdir app && mv bundle.js index.html pkg app` which is not really well documented. Besides this I noticed the `style.css` file is missing in the release tarball. It would be amazing if the files were made available in the releases (so I don't have to compile the thing myself) and already provided in the correct file structure. I can help with automating such a process with Github Actions if you're interested. Lastly, loading the webpage doesn't work because all of bootstrap assets have a mismatched `sha384`. I don't really think this is an issue on your side, but I just wanted to point it out.

kerem closed this issue

2026-02-27 08:15:35 +03:00

kerem commented

2026-02-27 08:15:35 +03:00

Author

Owner

@nitnelave commented on GitHub (Jan 5, 2023):

Thanks for the feedback!

Since the latest release, we made some progress with the release packaging (I should probably just release something so people would stop complaining about it :D ). But you're right that we were missing some things in the folder anyway. I think https://github.com/nitnelave/lldap/pull/409 should help?

@nitnelave commented on GitHub (Jan 5, 2023): Thanks for the feedback! Since the latest release, we made some progress with the release packaging (I should probably just release something so people would stop complaining about it :D ). But you're right that we were missing some things in the folder anyway. I think https://github.com/nitnelave/lldap/pull/409 should help?

kerem commented

2026-02-27 08:15:35 +03:00

Author

Owner

@lucat1 commented on GitHub (Jan 5, 2023):

Right. With the amd64-lldap-bin.zip and the ui.zip files from the latest GitHub Action for Docker static I can manage to get all the files in place indeed. I still had to move the contents of the ui.zip into the app` directory mysqlf. Feel free to close this issue whenever you want, though I believe it may be nice to get a release with all the files in the proper place in a single tar file before we consider this addressed.

I understand these assets are not really meant for installation rather they are just artifacts of the build process for the docker image, so I'm not expecting them to be properly placed on their own. I just think a release binary should have a working setup right from the start. Again, I can help with that if needed.

@lucat1 commented on GitHub (Jan 5, 2023): Right. With the `amd64-lldap-bin.zip` and the `ui.zip` files from the latest GitHub Action for Docker static I can manage to get all the files in place indeed. I still had to move the contents of the `ui.zip` into the app` directory mysqlf. Feel free to close this issue whenever you want, though I believe it may be nice to get a release with all the files in the proper place in a single tar file before we consider this addressed. I understand these assets are not really meant for installation rather they are just artifacts of the build process for the docker image, so I'm not expecting them to be properly placed on their own. I just think a release binary should have a working setup right from the start. Again, I can help with that if needed.

kerem commented

2026-02-27 08:15:36 +03:00

Author

Owner

@martadinata666 commented on GitHub (Jan 6, 2023):

This is a sample of next release, https://github.com/martadinata666/lldap/releases/tag/v0.4.2-alpha4

it will be grab the binary + extract web in the same dir with binary.

we can also pack it together, bin+web to single zip file. 🤔 should it?

@martadinata666 commented on GitHub (Jan 6, 2023): This is a sample of next release, https://github.com/martadinata666/lldap/releases/tag/v0.4.2-alpha4 it will be grab the binary + extract web in the same dir with binary. we can also pack it together, bin+web to single zip file. 🤔 should it?

kerem commented

2026-02-27 08:15:36 +03:00

Author

Owner

@nitnelave commented on GitHub (Jan 6, 2023):

If we can provide an "extract-and-run" tarball without too much hassle, let's do it.

@nitnelave commented on GitHub (Jan 6, 2023): If we can provide an "extract-and-run" tarball without too much hassle, let's do it.

kerem commented

2026-02-27 08:15:36 +03:00

Author

Owner

@nitnelave commented on GitHub (Jan 6, 2023):

Alright, I think with @martadinata666 's help, we have solved the issue. The next release will have a .tar.gz that is directly extractable+runnable (you still have to provide it with a config, but that's it) for each of the 3 supported arch. See https://github.com/nitnelave/lldap/pull/411

@nitnelave commented on GitHub (Jan 6, 2023): Alright, I think with @martadinata666 's help, we have solved the issue. The next release will have a .tar.gz that is directly extractable+runnable (you still have to provide it with a config, but that's it) for each of the 3 supported arch. See https://github.com/nitnelave/lldap/pull/411

kerem commented

2026-02-27 08:15:36 +03:00

Author

Owner

@ergofroggy commented on GitHub (Jan 23, 2023):

Hi,
Thanks for your work on this project, it really fills a niche for selfhosters that want a simple and straightfrowards LDAP provider.

I have a small issue which I believe is related to this one.
I tried out the 0.4.2-alpha14, which you can just extract and run, but I need to whitelist both jsdelivr.net and cloudflare in ublock origin for the page to load. Without these domains, lldap doesn't complain, but this is the error in my firefox console:
ross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://cdn.jsdelivr.net/npm/bootstrap@5.1.1/dist/js/bootstrap.bundle.min.js. (Reason: CORS request did not succeed). Status code: (null).
It seems the required files are actually in the release tarball under app/static/ but lldap doesn't seem to use them.
Would it be possible to fix this? I'm also happy to help.
Thanks

@ergofroggy commented on GitHub (Jan 23, 2023): Hi, Thanks for your work on this project, it really fills a niche for selfhosters that want a simple and straightfrowards LDAP provider. I have a small issue which I believe is related to this one. I tried out the [0.4.2-alpha14](https://github.com/martadinata666/lldap/releases/tag/v0.4.2-alpha14), which you can just extract and run, but I need to whitelist both jsdelivr.net and cloudflare in ublock origin for the page to load. Without these domains, lldap doesn't complain, but this is the error in my firefox console: `ross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://cdn.jsdelivr.net/npm/bootstrap@5.1.1/dist/js/bootstrap.bundle.min.js. (Reason: CORS request did not succeed). Status code: (null).` It seems the required files are actually in the release tarball under `app/static/` but lldap doesn't seem to use them. Would it be possible to fix this? I'm also happy to help. Thanks

kerem commented

2026-02-27 08:15:36 +03:00

Author

Owner

@martadinata666 commented on GitHub (Jan 23, 2023):

oh i see, the index should be using index_local.html, https://github.com/nitnelave/lldap/blob/main/app/index_local.html that using local downloaded assets. It used in docker, what do you think? @nitnelave should the release tar use index_local ?

@martadinata666 commented on GitHub (Jan 23, 2023): oh i see, the index should be using index_local.html, https://github.com/nitnelave/lldap/blob/main/app/index_local.html that using local downloaded assets. It used in docker, what do you think? @nitnelave should the release tar use `index_local` ?

kerem commented

2026-02-27 08:15:36 +03:00

Author

Owner

@nitnelave commented on GitHub (Jan 23, 2023):

Yeah, it makes sense to use the local resources.

On Mon, Jan 23, 2023 at 10:14 PM Dedy Martadinata S <
@.***> wrote:

oh i see, the index should be using index_local.html,
https://github.com/nitnelave/lldap/blob/main/app/index_local.html that
using local downloaded assets. It used in docker, what do you think?
@nitnelave https://github.com/nitnelave should the release tar use
index_local ?

—
Reply to this email directly, view it on GitHub
https://github.com/nitnelave/lldap/issues/408#issuecomment-1400987963,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGCPWP3LFRCR3M7XSGYYP3WT3YCRANCNFSM6AAAAAATRYTS44
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Valentin Tolmer

@nitnelave commented on GitHub (Jan 23, 2023): Yeah, it makes sense to use the local resources. On Mon, Jan 23, 2023 at 10:14 PM Dedy Martadinata S < ***@***.***> wrote: > oh i see, the index should be using index_local.html, > https://github.com/nitnelave/lldap/blob/main/app/index_local.html that > using local downloaded assets. It used in docker, what do you think? > @nitnelave <https://github.com/nitnelave> should the release tar use > index_local ? > > — > Reply to this email directly, view it on GitHub > <https://github.com/nitnelave/lldap/issues/408#issuecomment-1400987963>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGCPWP3LFRCR3M7XSGYYP3WT3YCRANCNFSM6AAAAAATRYTS44> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- Valentin Tolmer

kerem referenced this issue

2026-02-27 08:18:03 +03:00

[PR #157] [MERGED] ldap: return uids instead of cns for users #578