mirror of
https://github.com/lldap/lldap.git
synced 2026-04-25 08:15:52 +03:00
[GH-ISSUE #393] Remove Hardcoded Volume #149
Labels
No labels
backend
blocked
bug
cleanup
dependencies
docker
documentation
duplicate
enhancement
enhancement
frontend
github_actions
good first issue
help wanted
help wanted
integration
invalid
ldap
pull-request
question
rust
rust
tests
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/lldap-lldap#149
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @RedlineTriad on GitHub (Dec 11, 2022).
Original GitHub issue: https://github.com/lldap/lldap/issues/393
The LLDAP docker images include hardcoded volume paths.
Which means that if you don't want to mount all of
/datathen it will create an anonymous volume which is very annoying when deploying.In general I don't think
VOLUMEshould be used in Dockerfiles, since there is no way to change it afterwards.In my case I want
lldap_config.tomlto be mounted read only to the local file system, and then use/data/dynamicfor storing the database.docker-compose.ymlI can work around this by using a different directory for the database or config file, but it's still a bit cumbersome.
@nitnelave commented on GitHub (Dec 11, 2022):
I'm not sure I understand all of your concerns.
What prevents you from mounting all of /data, but then on top of it mount
the config readonly?
The dockerfile is primarily made for ease of use. For a new user, using the
image is the easiest. If you're an advanced user with a non standard use
case, that's also supported: we provide the dockerfile, you can either
modify it and build your own image, or build in top of it.
I'd rather not modify the standard image since it would require people to
migrate their docker compose configuration.
On Sun, 11 Dec 2022, 14:16 RedlineTriad, @.***> wrote:
@RedlineTriad commented on GitHub (Dec 11, 2022):
If you create a volume in
Dockerfilethere has to be a volume there no matter what.If you don't mount it, it creates an anonymous volume, there is no way to disable or block this.
Even if you only want to mount a sub-path, or not entirely, for a temporary test instance, it will still create it.
If you don't think any of this is important it's fine if you close this issue since I have my own workaround now.
@nitnelave commented on GitHub (Dec 21, 2022):
I think for most people it's fine to have an (almost empty) volume, even if it's not used. Those who know better can make their own Dockerfile and image.