[PR #1392] feat(server): add native HTTPS support for the web interface #1296

New issue

Open

opened 2026-02-27 09:11:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:11:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/1392
Author: @lyzstrik
Created: 1/31/2026
Status: 🔄 Open

Base: main ← Head: feat/native-https

📝 Commits (4)

32540bc feat(server): add native HTTPS support for the web interface
3710235 Update docs/install.md
1443849 fix(server): upgrade reqwest and fix healthcheck logic
25a1577 fix: coderabbitai issue

📊 Changes

9 files changed (+222 additions, -59 deletions)

View changed files

📝 Cargo.lock (+1 -1)
📝 docs/install.md (+11 -4)
📝 lldap_config.docker_template.toml (+10 -0)
📝 server/Cargo.toml (+2 -2)
📝 server/src/cli.rs (+23 -0)
📝 server/src/configuration.rs (+42 -2)
📝 server/src/healthcheck.rs (+37 -6)
📝 server/src/main.rs (+11 -3)
📝 server/src/tcp_server.rs (+85 -41)

📄 Description

This commit enables the web server to run natively over HTTPS, allowing secure deployments without requiring a reverse proxy.

Key changes:

Configuration: Added [https_options] to config and CLI arguments (port, cert/key paths, enabled flag).
Server: Updated tcp_server.rs to support binding with TLS.
Healthcheck: Added check_https which uses certificate pinning to verify identity.
Main: Updated healthcheck runner to check HTTP and HTTPS endpoints concurrently.
Docs: Updated install.md and lldap_config.docker_template.toml with HTTPS configuration examples.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/1392 **Author:** [@lyzstrik](https://github.com/lyzstrik) **Created:** 1/31/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/native-https` --- ### 📝 Commits (4) - [`32540bc`](https://github.com/lldap/lldap/commit/32540bcc21b92e3d9357dddc9b84b3c1d6e16ef5) feat(server): add native HTTPS support for the web interface - [`3710235`](https://github.com/lldap/lldap/commit/3710235f9d2097cfd615e1e9cdec1259f98af25d) Update docs/install.md - [`1443849`](https://github.com/lldap/lldap/commit/1443849259543f460ad4a28e779cc959224a311f) fix(server): upgrade reqwest and fix healthcheck logic - [`25a1577`](https://github.com/lldap/lldap/commit/25a15776a295579de579744f1db851f2ef1be3c6) fix: coderabbitai issue ### 📊 Changes **9 files changed** (+222 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -1) 📝 `docs/install.md` (+11 -4) 📝 `lldap_config.docker_template.toml` (+10 -0) 📝 `server/Cargo.toml` (+2 -2) 📝 `server/src/cli.rs` (+23 -0) 📝 `server/src/configuration.rs` (+42 -2) 📝 `server/src/healthcheck.rs` (+37 -6) 📝 `server/src/main.rs` (+11 -3) 📝 `server/src/tcp_server.rs` (+85 -41) </details> ### 📄 Description This commit enables the web server to run natively over HTTPS, allowing secure deployments without requiring a reverse proxy. Key changes: - Configuration: Added `[https_options]` to config and CLI arguments (port, cert/key paths, enabled flag). - Server: Updated `tcp_server.rs` to support binding with TLS. - Healthcheck: Added `check_https` which uses certificate pinning to verify identity. - Main: Updated healthcheck runner to check HTTP and HTTPS endpoints concurrently. - Docs: Updated `install.md` and `lldap_config.docker_template.toml` with HTTPS configuration examples. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>