[PR #1325] [MERGED] server: allow specifying the healthcheck addresses #1258

New issue

Closed

opened 2026-02-27 09:11:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:11:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/1325
Author: @sdwilsh
Created: 10/11/2025
Status: ✅ Merged
Merged: 11/16/2025
Merged by: @nitnelave

Base: main ← Head: healthcheck-args

📝 Commits (1)

9a95373 server: allow specifying the healthcheck addresses

📊 Changes

5 files changed (+79 additions, -15 deletions)

View changed files

📝 lldap_config.docker_template.toml (+13 -0)
📝 server/src/cli.rs (+15 -0)
📝 server/src/configuration.rs (+31 -2)
📝 server/src/healthcheck.rs (+8 -10)
📝 server/src/main.rs (+12 -3)

📄 Description

This change adds two new optional configuration options:

ldap_healthcheck_host to pair with ldap_host
http_healthcheck_host to pair with http_host

These new options will allow someone to specify a specific address for ldap_host and http_host and still have functional health checks, as health checks were previously hard-coded to check against localhost prior to this change. These new settings default to localhost to preserve the existing behavior.

Fixes #700

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/1325 **Author:** [@sdwilsh](https://github.com/sdwilsh) **Created:** 10/11/2025 **Status:** ✅ Merged **Merged:** 11/16/2025 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `healthcheck-args` --- ### 📝 Commits (1) - [`9a95373`](https://github.com/lldap/lldap/commit/9a9537337e703c6e3408347717fa0f25fb3d11a1) server: allow specifying the healthcheck addresses ### 📊 Changes **5 files changed** (+79 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `lldap_config.docker_template.toml` (+13 -0) 📝 `server/src/cli.rs` (+15 -0) 📝 `server/src/configuration.rs` (+31 -2) 📝 `server/src/healthcheck.rs` (+8 -10) 📝 `server/src/main.rs` (+12 -3) </details> ### 📄 Description This change adds two new optional configuration options: - `ldap_healthcheck_host` to pair with `ldap_host` - `http_healthcheck_host` to pair with `http_host` These new options will allow someone to specify a specific address for `ldap_host` and `http_host` and still have functional health checks, as health checks were previously hard-coded to check against `localhost` prior to this change. These new settings default to `localhost` to preserve the existing behavior. Fixes #700 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>