[PR #1287] [MERGED] chore: upgrade Rust toolchain to 1.89 and modernize code with let-chains #1234

New issue

Closed

opened 2026-02-27 09:11:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:11:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/1287
Author: @Kumpelinus
Created: 9/13/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @nitnelave

Base: main ← Head: bump-msrv-1-89-0

📝 Commits (1)

f4450cb chore: upgrade Rust toolchain to 1.89 and modernize code with let-chains

📊 Changes

27 files changed (+62 additions, -33 deletions)

View changed files

📝 .devcontainer/Dockerfile (+1 -1)
📝 .github/workflows/Dockerfile.dev (+1 -1)
📝 .github/workflows/docker-build-static.yml (+13 -3)
📝 .github/workflows/rust.yml (+2 -2)
📝 Cargo.toml (+1 -0)
📝 app/Cargo.toml (+1 -0)
📝 app/src/components/form/file_input.rs (+12 -14)
📝 app/src/infra/attributes.rs (+4 -4)
📝 app/src/lib.rs (+1 -0)
📝 crates/access-control/Cargo.toml (+1 -0)
📝 crates/auth/Cargo.toml (+1 -0)
📝 crates/domain-handlers/Cargo.toml (+1 -0)
📝 crates/domain-model/Cargo.toml (+1 -0)
📝 crates/domain/Cargo.toml (+1 -0)
📝 crates/frontend-options/Cargo.toml (+1 -0)
📝 crates/graphql-server/Cargo.toml (+2 -1)
📝 crates/ldap/Cargo.toml (+2 -1)
📝 crates/ldap/src/search.rs (+6 -6)
📝 crates/opaque-handler/Cargo.toml (+1 -0)
📝 crates/sql-backend-handler/Cargo.toml (+1 -0)

...and 7 more files

📄 Description

Upgrades Rust from 1.85 to 1.89 across Docker files, CI workflows, and MSRV
Adds rust-toolchain.toml to pin project toolchain version
Modernizes code with let-chain syntax replacing nested if-let patterns
Updates lifetime annotations in attribute description functions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/1287 **Author:** [@Kumpelinus](https://github.com/Kumpelinus) **Created:** 9/13/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `bump-msrv-1-89-0` --- ### 📝 Commits (1) - [`f4450cb`](https://github.com/lldap/lldap/commit/f4450cb6fe359701dea0d5b46f418f3160b749a5) chore: upgrade Rust toolchain to 1.89 and modernize code with let-chains ### 📊 Changes **27 files changed** (+62 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+1 -1) 📝 `.github/workflows/Dockerfile.dev` (+1 -1) 📝 `.github/workflows/docker-build-static.yml` (+13 -3) 📝 `.github/workflows/rust.yml` (+2 -2) 📝 `Cargo.toml` (+1 -0) 📝 `app/Cargo.toml` (+1 -0) 📝 `app/src/components/form/file_input.rs` (+12 -14) 📝 `app/src/infra/attributes.rs` (+4 -4) 📝 `app/src/lib.rs` (+1 -0) 📝 `crates/access-control/Cargo.toml` (+1 -0) 📝 `crates/auth/Cargo.toml` (+1 -0) 📝 `crates/domain-handlers/Cargo.toml` (+1 -0) 📝 `crates/domain-model/Cargo.toml` (+1 -0) 📝 `crates/domain/Cargo.toml` (+1 -0) 📝 `crates/frontend-options/Cargo.toml` (+1 -0) 📝 `crates/graphql-server/Cargo.toml` (+2 -1) 📝 `crates/ldap/Cargo.toml` (+2 -1) 📝 `crates/ldap/src/search.rs` (+6 -6) 📝 `crates/opaque-handler/Cargo.toml` (+1 -0) 📝 `crates/sql-backend-handler/Cargo.toml` (+1 -0) _...and 7 more files_ </details> ### 📄 Description - Upgrades Rust from 1.85 to 1.89 across Docker files, CI workflows, and MSRV - Adds `rust-toolchain.toml` to pin project toolchain version - Modernizes code with let-chain syntax replacing nested if-let patterns - Updates lifetime annotations in attribute description functions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>