[PR #1286] [CLOSED] chore: upgrade Rust toolchain to 1.89 and modernize code with let-chains #1233

New issue

Closed

opened 2026-02-27 09:11:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:11:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/1286
Author: @Kumpelinus
Created: 9/13/2025
Status: ❌ Closed

Base: main ← Head: bump-msrv-1-89-0

📄 Description

Upgrades Rust from 1.85 to 1.89 across Docker files, CI workflows, and MSRV
Adds rust-toolchain.toml to pin project toolchain version
Modernizes code with let-chain syntax replacing nested if-let patterns
Updates lifetime annotations in attribute description functions

Summary by CodeRabbit

Chores
- Upgraded Rust toolchain to 1.89 across the project for consistent builds.
- Updated dev container and CI images; pinned toolchain for build, test, and schema tasks.
- Added repository toolchain configuration and adjusted lint settings to reduce warnings.
Refactor
- Simplified internal control flow for improved readability with no behavior changes.
Tests
- Reduced noise in test utilities by suppressing non-impactful warnings.

No user-facing changes; stability and build consistency improved.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/1286 **Author:** [@Kumpelinus](https://github.com/Kumpelinus) **Created:** 9/13/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bump-msrv-1-89-0` --- ### 📄 Description - Upgrades Rust from 1.85 to 1.89 across Docker files, CI workflows, and MSRV - Adds `rust-toolchain.toml` to pin project toolchain version - Modernizes code with let-chain syntax replacing nested if-let patterns - Updates lifetime annotations in attribute description functions  ## Summary by CodeRabbit - Chores - Upgraded Rust toolchain to 1.89 across the project for consistent builds. - Updated dev container and CI images; pinned toolchain for build, test, and schema tasks. - Added repository toolchain configuration and adjusted lint settings to reduce warnings. - Refactor - Simplified internal control flow for improved readability with no behavior changes. - Tests - Reduced noise in test utilities by suppressing non-impactful warnings. No user-facing changes; stability and build consistency improved.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>