[PR #1278] [CLOSED] feat: DB_OPTIONS__* to replace and extend DATABASE_URL #1227

New issue

Closed

opened 2026-02-27 09:11:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:11:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/1278
Author: @thielj
Created: 9/5/2025
Status: ❌ Closed

Base: main ← Head: pr-db_options

📝 Commits (3)

f0151ca DB Connection Pool configuration
f9bdff7 fix cargo fmt issues ; add server shutdown log statement
ebb1fe1 feat: DB_OPTIONS (cont.)

📊 Changes

4 files changed (+154 additions, -36 deletions)

View changed files

📝 lldap_config.docker_template.toml (+18 -13)
📝 server/src/cli.rs (+31 -0)
📝 server/src/configuration.rs (+60 -4)
📝 server/src/main.rs (+45 -19)

📄 Description

PR 2/3 -- should apply independently of PR1.

This PR reorganizes database configuration and adds support for configurable database connection options.

Changes:

Added support for configuring database pool and connection parameters
Updated default connection pool sizes:
- SQLite: min 1, max 4 connections
- Other DBs: min 4, max 8 connections
Added server shutdown logging
Updated lldap_config.docker_template.toml

Motivation:

The new [db_options] section provides better organization of database-related configuration and allows for more granular control over connection pooling, which can improve performance and resource usage.

Breaking Changes:

Configuration file format has changed - database_url now lives under [db_options] as url
Environment variable naming: use LLDAP_DB_OPTIONS__URL instead of LLDAP_DATABASE_URL - same pattern as other sub sections

Testing:

Configuration parsing tests updated
Build validation successful
Connection pool limits verified

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/1278 **Author:** [@thielj](https://github.com/thielj) **Created:** 9/5/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `pr-db_options` --- ### 📝 Commits (3) - [`f0151ca`](https://github.com/lldap/lldap/commit/f0151cad505c7bec5279d8f83472cc48ab3e00d6) DB Connection Pool configuration - [`f9bdff7`](https://github.com/lldap/lldap/commit/f9bdff78150ae9f35664304eb95cd8a0375ca6f7) fix cargo fmt issues ; add server shutdown log statement - [`ebb1fe1`](https://github.com/lldap/lldap/commit/ebb1fe1ceab16879965dca3b88648a364edcd3b4) feat: DB_OPTIONS (cont.) ### 📊 Changes **4 files changed** (+154 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `lldap_config.docker_template.toml` (+18 -13) 📝 `server/src/cli.rs` (+31 -0) 📝 `server/src/configuration.rs` (+60 -4) 📝 `server/src/main.rs` (+45 -19) </details> ### 📄 Description PR 2/3 -- should apply independently of PR1. This PR reorganizes database configuration and adds support for configurable database connection options. ### Changes: - Added support for configuring database pool and connection parameters - Updated default connection pool sizes: - SQLite: min 1, max 4 connections - Other DBs: min 4, max 8 connections - Added server shutdown logging - Updated `lldap_config.docker_template.toml` ### Motivation: The new `[db_options]` section provides better organization of database-related configuration and allows for more granular control over connection pooling, which can improve performance and resource usage. ### Breaking Changes: - Configuration file format has changed - `database_url` now lives under `[db_options]` as `url` - Environment variable naming: use `LLDAP_DB_OPTIONS__URL` instead of `LLDAP_DATABASE_URL` - same pattern as other sub sections ### Testing: - Configuration parsing tests updated - Build validation successful - Connection pool limits verified --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>