[PR #1257] [CLOSED] Chore: pin the rust version in CI to 1.85.0 and use action-rs/toolchain #1214

New issue

Closed

opened 2026-02-27 09:11:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:11:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/1257
Author: @Copilot
Created: 8/20/2025
Status: ❌ Closed

Base: main ← Head: copilot/fix-1256

📝 Commits (3)

4d8fccb Initial plan
2e2a67c Pin Rust version to 1.85.0 in CI workflows and Docker images
30cb4ce Use variable for Rust version in CI workflow

📊 Changes

5 files changed (+24 additions, -5 deletions)

View changed files

📝 .devcontainer/Dockerfile (+1 -1)
📝 .github/workflows/Dockerfile.dev (+1 -1)
📝 .github/workflows/rust.yml (+20 -2)
📝 Cargo.toml (+1 -0)
📝 Dockerfile (+1 -1)

📄 Description

Pins Rust version to 1.85.0 across all CI workflows and Docker images to ensure consistent builds and prevent issues from Rust version drift. Updates the CI workflow to use action-rs/toolchain for consistent Rust installation with appropriate components.

Changes Made:

Updated rust.yml workflow to use RUST_VERSION environment variable set to "1.85.0"
Switched from dtolnay/rust-toolchain to action-rs/toolchain@v1 for Rust installation
Added specific components for each job:
- clippy component for the clippy job
- rustfmt component for the format job
- llvm-tools-preview component for the coverage job
Updated all Docker images to use exact Rust 1.85.0 versions:
- Development Docker image: rust:1.85.0-slim-bookworm
- Devcontainer: rust:1.85.0
- Main Dockerfile: rust:1.85.0-alpine3.21
Added rust-version = "1.85.0" to workspace Cargo.toml for MSRV enforcement

This ensures all CI jobs (test, clippy, format, coverage) and Docker builds use the same Rust version with consistent toolchain installation, making builds more predictable and easier to maintain.

Fixes #1256.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/1257 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 8/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `copilot/fix-1256` --- ### 📝 Commits (3) - [`4d8fccb`](https://github.com/lldap/lldap/commit/4d8fccb5028a145a0542a6d137a1f47008131aaf) Initial plan - [`2e2a67c`](https://github.com/lldap/lldap/commit/2e2a67c13bfc4731f8a515807b5988545a6b5262) Pin Rust version to 1.85.0 in CI workflows and Docker images - [`30cb4ce`](https://github.com/lldap/lldap/commit/30cb4ceae00511b580f3f893e67cefd27fa934f7) Use variable for Rust version in CI workflow ### 📊 Changes **5 files changed** (+24 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+1 -1) 📝 `.github/workflows/Dockerfile.dev` (+1 -1) 📝 `.github/workflows/rust.yml` (+20 -2) 📝 `Cargo.toml` (+1 -0) 📝 `Dockerfile` (+1 -1) </details> ### 📄 Description Pins Rust version to 1.85.0 across all CI workflows and Docker images to ensure consistent builds and prevent issues from Rust version drift. Updates the CI workflow to use `action-rs/toolchain` for consistent Rust installation with appropriate components. ## Changes Made: - Updated `rust.yml` workflow to use `RUST_VERSION` environment variable set to "1.85.0" - Switched from `dtolnay/rust-toolchain` to `action-rs/toolchain@v1` for Rust installation - Added specific components for each job: - `clippy` component for the clippy job - `rustfmt` component for the format job - `llvm-tools-preview` component for the coverage job - Updated all Docker images to use exact Rust 1.85.0 versions: - Development Docker image: `rust:1.85.0-slim-bookworm` - Devcontainer: `rust:1.85.0` - Main Dockerfile: `rust:1.85.0-alpine3.21` - Added `rust-version = "1.85.0"` to workspace Cargo.toml for MSRV enforcement This ensures all CI jobs (test, clippy, format, coverage) and Docker builds use the same Rust version with consistent toolchain installation, making builds more predictable and easier to maintain. Fixes #1256.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/lldap/lldap/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>