[PR #1228] [MERGED] bootstrap: do not leak password in process list #1194

New issue

Closed

opened 2026-02-27 09:11:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:11:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/1228
Author: @ibizaman
Created: 7/21/2025
Status: ✅ Merged
Merged: 7/22/2025
Merged by: @nitnelave

Base: main ← Head: boostrap_leak

📝 Commits (1)

9153331 bootstrap: do not leak password in process list

📊 Changes

2 files changed (+14 additions, -6 deletions)

View changed files

📝 scripts/bootstrap.sh (+2 -2)
📝 set-password/src/main.rs (+12 -4)

📄 Description

As discussed in a comment, we should use a variable to hold the password to avoid leaking it in the process list.

Btw I've tried to merge the body of the two if clauses but I couldn't come up with something more elegant.

This was tested in https://github.com/NixOS/nixpkgs/pull/425923

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/1228 **Author:** [@ibizaman](https://github.com/ibizaman) **Created:** 7/21/2025 **Status:** ✅ Merged **Merged:** 7/22/2025 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `boostrap_leak` --- ### 📝 Commits (1) - [`9153331`](https://github.com/lldap/lldap/commit/9153331367bd249ffb73e52a434b879a098193e6) bootstrap: do not leak password in process list ### 📊 Changes **2 files changed** (+14 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `scripts/bootstrap.sh` (+2 -2) 📝 `set-password/src/main.rs` (+12 -4) </details> ### 📄 Description As discussed [in a comment](https://github.com/lldap/lldap/pull/1218#discussion_r2218854469), we should use a variable to hold the password to avoid leaking it in the process list. Btw I've tried to merge the body of the two if clauses but I couldn't come up with something more elegant. This was tested in https://github.com/NixOS/nixpkgs/pull/425923 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>