[PR #1217] [MERGED] meta: Fix cargo clippy failures (format strings) #1184

New issue

Closed

opened 2026-02-27 09:11:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:11:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/1217
Author: @selfhoster1312
Created: 7/16/2025
Status: ✅ Merged
Merged: 7/16/2025
Merged by: @nitnelave

Base: main ← Head: meta-clippy-failure

📝 Commits (1)

825de9f meta: Fix cargo clippy failures (format strings)

📊 Changes

28 files changed (+88 additions, -125 deletions)

View changed files

📝 crates/domain/src/deserialize.rs (+2 -2)
📝 crates/domain/src/types.rs (+1 -1)
📝 crates/graphql-server/src/api.rs (+1 -1)
📝 crates/ldap/src/core/group.rs (+6 -8)
📝 crates/ldap/src/core/user.rs (+4 -8)
📝 crates/ldap/src/core/utils.rs (+6 -7)
📝 crates/ldap/src/create.rs (+5 -11)
📝 crates/ldap/src/delete.rs (+5 -8)
📝 crates/ldap/src/handler.rs (+4 -7)
📝 crates/ldap/src/modify.rs (+5 -5)
📝 crates/ldap/src/password.rs (+3 -4)
📝 crates/ldap/src/search.rs (+1 -1)
📝 crates/sql-backend-handler/src/sql_backend_handler.rs (+1 -1)
📝 crates/sql-backend-handler/src/sql_group_backend_handler.rs (+3 -5)
📝 crates/sql-backend-handler/src/sql_user_backend_handler.rs (+3 -6)
📝 server/src/auth_service.rs (+5 -6)
📝 server/src/configuration.rs (+8 -10)
📝 server/src/database_string.rs (+2 -2)
📝 server/src/healthcheck.rs (+2 -2)
📝 server/src/ldap_server.rs (+1 -4)

...and 8 more files

📄 Description

I noticed in #1216 clippy was failing, not only because of the PR changes.

In this PR i apply clippy suggestions to make it happy.

In the future we may want to pin clippy/fmt to a specific version to avoid breaking CI due to the Github Actions upgrading to a newer release.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/1217 **Author:** [@selfhoster1312](https://github.com/selfhoster1312) **Created:** 7/16/2025 **Status:** ✅ Merged **Merged:** 7/16/2025 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `meta-clippy-failure` --- ### 📝 Commits (1) - [`825de9f`](https://github.com/lldap/lldap/commit/825de9fe176fa409651ef6052268965475846800) meta: Fix cargo clippy failures (format strings) ### 📊 Changes **28 files changed** (+88 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `crates/domain/src/deserialize.rs` (+2 -2) 📝 `crates/domain/src/types.rs` (+1 -1) 📝 `crates/graphql-server/src/api.rs` (+1 -1) 📝 `crates/ldap/src/core/group.rs` (+6 -8) 📝 `crates/ldap/src/core/user.rs` (+4 -8) 📝 `crates/ldap/src/core/utils.rs` (+6 -7) 📝 `crates/ldap/src/create.rs` (+5 -11) 📝 `crates/ldap/src/delete.rs` (+5 -8) 📝 `crates/ldap/src/handler.rs` (+4 -7) 📝 `crates/ldap/src/modify.rs` (+5 -5) 📝 `crates/ldap/src/password.rs` (+3 -4) 📝 `crates/ldap/src/search.rs` (+1 -1) 📝 `crates/sql-backend-handler/src/sql_backend_handler.rs` (+1 -1) 📝 `crates/sql-backend-handler/src/sql_group_backend_handler.rs` (+3 -5) 📝 `crates/sql-backend-handler/src/sql_user_backend_handler.rs` (+3 -6) 📝 `server/src/auth_service.rs` (+5 -6) 📝 `server/src/configuration.rs` (+8 -10) 📝 `server/src/database_string.rs` (+2 -2) 📝 `server/src/healthcheck.rs` (+2 -2) 📝 `server/src/ldap_server.rs` (+1 -4) _...and 8 more files_ </details> ### 📄 Description I noticed in #1216 clippy was failing, not only because of the PR changes. In this PR i apply clippy suggestions to make it happy. In the future we may want to pin clippy/fmt to a specific version to avoid breaking CI due to the Github Actions upgrading to a newer release. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>