[PR #1108] [MERGED] domain-model: move domain::model module to separate crate #1123

New issue

Closed

opened 2026-02-27 09:10:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:10:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/1108
Author: @broeng
Created: 2/19/2025
Status: ✅ Merged
Merged: 2/21/2025
Merged by: @nitnelave

Base: main ← Head: domain-model-crate

📝 Commits (1)

525c447 domain-model: move domain::model module to separate crate

📊 Changes

39 files changed (+125 additions, -42 deletions)

View changed files

📝 Cargo.lock (+20 -0)
📝 Cargo.toml (+1 -0)
➕ crates/domain-model/Cargo.toml (+50 -0)
📝 crates/domain-model/src/error.rs (+0 -0)
➕ crates/domain-model/src/lib.rs (+2 -0)
📝 crates/domain-model/src/model/deserialize.rs (+3 -3)
📝 crates/domain-model/src/model/group_attribute_schema.rs (+0 -0)
📝 crates/domain-model/src/model/group_attributes.rs (+0 -0)
📝 crates/domain-model/src/model/group_object_classes.rs (+0 -0)
📝 crates/domain-model/src/model/groups.rs (+0 -0)
📝 crates/domain-model/src/model/jwt_refresh_storage.rs (+0 -0)
📝 crates/domain-model/src/model/jwt_storage.rs (+0 -0)
📝 crates/domain-model/src/model/memberships.rs (+0 -0)
📝 crates/domain-model/src/model/mod.rs (+1 -1)
📝 crates/domain-model/src/model/password_reset_tokens.rs (+0 -0)
📝 crates/domain-model/src/model/prelude.rs (+0 -0)
📝 crates/domain-model/src/model/user_attribute_schema.rs (+0 -0)
📝 crates/domain-model/src/model/user_attributes.rs (+0 -0)
📝 crates/domain-model/src/model/user_object_classes.rs (+0 -0)
📝 crates/domain-model/src/model/users.rs (+0 -0)

...and 19 more files

📄 Description

This PR moves the database model related types from domain::model to a separate crate.

It also includes error::Result and error::DomainError, as these will be required for a future extraction of the backend handler traits to a separate crate. It could be argued they might fit better in the domain crate, or elsewhere entirely, but the error conditions are mostly database related, so I included them here. Suggestions are welcome. :-)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/1108 **Author:** [@broeng](https://github.com/broeng) **Created:** 2/19/2025 **Status:** ✅ Merged **Merged:** 2/21/2025 **Merged by:** [@nitnelave](https://github.com/nitnelave) **Base:** `main` ← **Head:** `domain-model-crate` --- ### 📝 Commits (1) - [`525c447`](https://github.com/lldap/lldap/commit/525c447f075b241abdf4f408e49b8e19830b14cc) domain-model: move domain::model module to separate crate ### 📊 Changes **39 files changed** (+125 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+20 -0) 📝 `Cargo.toml` (+1 -0) ➕ `crates/domain-model/Cargo.toml` (+50 -0) 📝 `crates/domain-model/src/error.rs` (+0 -0) ➕ `crates/domain-model/src/lib.rs` (+2 -0) 📝 `crates/domain-model/src/model/deserialize.rs` (+3 -3) 📝 `crates/domain-model/src/model/group_attribute_schema.rs` (+0 -0) 📝 `crates/domain-model/src/model/group_attributes.rs` (+0 -0) 📝 `crates/domain-model/src/model/group_object_classes.rs` (+0 -0) 📝 `crates/domain-model/src/model/groups.rs` (+0 -0) 📝 `crates/domain-model/src/model/jwt_refresh_storage.rs` (+0 -0) 📝 `crates/domain-model/src/model/jwt_storage.rs` (+0 -0) 📝 `crates/domain-model/src/model/memberships.rs` (+0 -0) 📝 `crates/domain-model/src/model/mod.rs` (+1 -1) 📝 `crates/domain-model/src/model/password_reset_tokens.rs` (+0 -0) 📝 `crates/domain-model/src/model/prelude.rs` (+0 -0) 📝 `crates/domain-model/src/model/user_attribute_schema.rs` (+0 -0) 📝 `crates/domain-model/src/model/user_attributes.rs` (+0 -0) 📝 `crates/domain-model/src/model/user_object_classes.rs` (+0 -0) 📝 `crates/domain-model/src/model/users.rs` (+0 -0) _...and 19 more files_ </details> ### 📄 Description This PR moves the database model related types from domain::model to a separate crate. It also includes error::Result and error::DomainError, as these will be required for a future extraction of the backend handler traits to a separate crate. It could be argued they might fit better in the domain crate, or elsewhere entirely, but the error conditions are mostly database related, so I included them here. Suggestions are welcome. :-) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>