[PR #942] [CLOSED] Completing the work on the user_attributes branch #1028

New issue

Closed

opened 2026-02-27 09:10:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 09:10:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lldap/lldap/pull/942
Author: @bojidar-bg
Created: 7/30/2024
Status: ❌ Closed

Base: user_attributes ← Head: user_attributes

📝 Commits (10+)

d33d9a1 commit so i can pull in fixes from master
5b96f3b test point
ecdf145 WIP
799e667 WIP
26ccb76 fix: Fix broken user saving, and don't re-save attributes with no values
56681cd feat: Allow editing list fields (dirty functional WIP)
7d5911e feat: Pretty output of attribute names in edit form
a09c65d fix: Use bootstrap's tooltips to have field names visible on mobile too
5896d68 app: Reimplement ListAttributeInput with struct components
8c2e79b app: Reintroduce avatar input for attributes

📊 Changes

24 files changed (+1087 additions, -380 deletions)

View changed files

📝 app/Cargo.toml (+4 -0)
📝 app/queries/get_user_details.graphql (+17 -3)
📝 app/src/components/avatar.rs (+1 -0)
📝 app/src/components/create_user.rs (+112 -42)
➕ app/src/components/form/attribute_input.rs (+205 -0)
➕ app/src/components/form/date_input.rs (+41 -0)
➕ app/src/components/form/file_input.rs (+250 -0)
📝 app/src/components/form/mod.rs (+3 -0)
📝 app/src/components/user_details.rs (+31 -15)
📝 app/src/components/user_details_form.rs (+138 -245)
📝 app/src/infra/functional.rs (+16 -9)
📝 app/src/infra/mod.rs (+1 -0)
📝 app/src/infra/schema.rs (+12 -12)
➕ app/src/infra/tooltip.rs (+15 -0)
📝 migration-tool/src/ldap.rs (+1 -1)
📝 schema.graphql (+1 -1)
📝 server/src/domain/handler.rs (+1 -1)
📝 server/src/domain/sql_backend_handler.rs (+1 -1)
📝 server/src/domain/sql_user_backend_handler.rs (+209 -25)
📝 server/src/infra/graphql/mutation.rs (+4 -2)

...and 4 more files

📄 Description

Not sure what's left to fix; some fixes are probably best cherry-picked into separate PRs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lldap/lldap/pull/942 **Author:** [@bojidar-bg](https://github.com/bojidar-bg) **Created:** 7/30/2024 **Status:** ❌ Closed **Base:** `user_attributes` ← **Head:** `user_attributes` --- ### 📝 Commits (10+) - [`d33d9a1`](https://github.com/lldap/lldap/commit/d33d9a18069d65dea9b1be2555309a7b398dabb5) commit so i can pull in fixes from master - [`5b96f3b`](https://github.com/lldap/lldap/commit/5b96f3bff98c4595fc5e9a9408ef6fe2a481135f) test point - [`ecdf145`](https://github.com/lldap/lldap/commit/ecdf145f3d385e15838bc803d34af5d39ce3eee4) WIP - [`799e667`](https://github.com/lldap/lldap/commit/799e6676b6c93f6195f28b221e66122aed57cc02) WIP - [`26ccb76`](https://github.com/lldap/lldap/commit/26ccb7615960e0bd530fe686626f375f1290bc57) fix: Fix broken user saving, and don't re-save attributes with no values - [`56681cd`](https://github.com/lldap/lldap/commit/56681cdf297c1747e8eb8bc10fb5abea18e3e92c) feat: Allow editing list fields (dirty functional WIP) - [`7d5911e`](https://github.com/lldap/lldap/commit/7d5911e4b337434753a60268caaefbafb663af1f) feat: Pretty output of attribute names in edit form - [`a09c65d`](https://github.com/lldap/lldap/commit/a09c65daa83efcc71771241a878856589deeea7c) fix: Use bootstrap's tooltips to have field names visible on mobile too - [`5896d68`](https://github.com/lldap/lldap/commit/5896d686c21881ad7cce7a44e486ac0991d854aa) app: Reimplement ListAttributeInput with struct components - [`8c2e79b`](https://github.com/lldap/lldap/commit/8c2e79b555cd63dfddcbe11857bf6dff3e27adc1) app: Reintroduce avatar input for attributes ### 📊 Changes **24 files changed** (+1087 additions, -380 deletions) <details> <summary>View changed files</summary> 📝 `app/Cargo.toml` (+4 -0) 📝 `app/queries/get_user_details.graphql` (+17 -3) 📝 `app/src/components/avatar.rs` (+1 -0) 📝 `app/src/components/create_user.rs` (+112 -42) ➕ `app/src/components/form/attribute_input.rs` (+205 -0) ➕ `app/src/components/form/date_input.rs` (+41 -0) ➕ `app/src/components/form/file_input.rs` (+250 -0) 📝 `app/src/components/form/mod.rs` (+3 -0) 📝 `app/src/components/user_details.rs` (+31 -15) 📝 `app/src/components/user_details_form.rs` (+138 -245) 📝 `app/src/infra/functional.rs` (+16 -9) 📝 `app/src/infra/mod.rs` (+1 -0) 📝 `app/src/infra/schema.rs` (+12 -12) ➕ `app/src/infra/tooltip.rs` (+15 -0) 📝 `migration-tool/src/ldap.rs` (+1 -1) 📝 `schema.graphql` (+1 -1) 📝 `server/src/domain/handler.rs` (+1 -1) 📝 `server/src/domain/sql_backend_handler.rs` (+1 -1) 📝 `server/src/domain/sql_user_backend_handler.rs` (+209 -25) 📝 `server/src/infra/graphql/mutation.rs` (+4 -2) _...and 4 more files_ </details> ### 📄 Description Not sure what's left to fix; some fixes are probably best cherry-picked into separate PRs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>