[PR #605] [MERGED] Fix state toggling in SpircCommand::PlayPause #996

New issue

Closed

opened 2026-02-27 20:00:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/605
Author: @flaktack
Created: 2/20/2021
Status: ✅ Merged
Merged: 2/21/2021
Merged by: @sashahilton00

Base: dev ← Head: spirc-command-play-pause

📝 Commits (1)

392a12a Fix toggling in SpircCommand::PlayPause

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 connect/src/spirc.rs (+1 -1)

📄 Description

Fix play/pause toggling in handle_play_pause() to correctly call handle_play()/handle_pause() based on the state.

Currently for both playing and paused states handle_play() is called.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/605 **Author:** [@flaktack](https://github.com/flaktack) **Created:** 2/20/2021 **Status:** ✅ Merged **Merged:** 2/21/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `spirc-command-play-pause` --- ### 📝 Commits (1) - [`392a12a`](https://github.com/librespot-org/librespot/commit/392a12af9262dbec25c197f7b4cac37162bdd163) Fix toggling in SpircCommand::PlayPause ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/spirc.rs` (+1 -1) </details> ### 📄 Description Fix play/pause toggling in `handle_play_pause()` to correctly call `handle_play()`/`handle_pause()` based on the state. Currently for both playing and paused states `handle_play()` is called. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:45 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#996

No description provided.

Rows
Columns