[PR #587] [MERGED] Refactor SpotifyId #984

New issue

Closed

opened 2026-02-27 20:00:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/587
Author: @Johannesd3
Created: 1/29/2021
Status: ✅ Merged
Merged: 1/30/2021
Merged by: @sashahilton00

Base: dev ← Head: refactor-spotify-id

📝 Commits (2)

6b09836 Refactor SpotifyId
e582f0a Improved SpotifyId implementation

📊 Changes

1 file changed (+340 additions, -68 deletions)

View changed files

📝 core/src/spotify_id.rs (+340 -68)

📄 Description

This PR picks up the effort made in #459 to refactor SpotifyId. Since @alcore seems not to be interested anymore, I rebased it and applied some minor changes.

As stated in the original PR, the performance increases significantly, but the code is sometimes more complex. It could be discussed whether the uses of unsafe or some manual optimizations are worth the speedup if there's another simpler solution that is not too slow.

Is there anything else that has to be done before this PR could get merged?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/587 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 1/29/2021 **Status:** ✅ Merged **Merged:** 1/30/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `refactor-spotify-id` --- ### 📝 Commits (2) - [`6b09836`](https://github.com/librespot-org/librespot/commit/6b0983611750e55346cb4f5c27d3b5470eb6a98f) Refactor SpotifyId - [`e582f0a`](https://github.com/librespot-org/librespot/commit/e582f0a3fc373df0cb216fbf79b81fe4c4a9aa19) Improved SpotifyId implementation ### 📊 Changes **1 file changed** (+340 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `core/src/spotify_id.rs` (+340 -68) </details> ### 📄 Description This PR picks up the effort made in #459 to refactor SpotifyId. Since @alcore seems not to be interested anymore, I rebased it and applied some minor changes. As stated in the original PR, the performance increases significantly, but the code is sometimes more complex. It could be discussed whether the uses of `unsafe` or some manual optimizations are worth the speedup if there's another simpler solution that is not too slow. Is there anything else that has to be done before this PR could get merged? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#984

No description provided.

Rows
Columns