[PR #583] [MERGED] Proxy support in tokio migration #982

New issue

Closed

opened 2026-02-27 20:00:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/583
Author: @Johannesd3
Created: 1/26/2021
Status: ✅ Merged
Merged: 2/10/2021
Merged by: @ashthespy

Base: tokio_migration ← Head: tokio_migration_proxy

📝 Commits (5)

07514c9 Add proxy support to apresolve
c97fdeb Replaced .fold(0, add) by .sum()
a45fe85 Enable logging in test
c1d62d7 Fixed ProxyTunnel
bb44b99 Use proxytunnel in apresolve

📊 Changes

8 files changed (+190 additions, -55 deletions)

View changed files

📝 Cargo.lock (+62 -0)
📝 audio/src/range_set.rs (+1 -1)
📝 core/Cargo.toml (+2 -0)
📝 core/src/apresolve.rs (+10 -18)
📝 core/src/connection/mod.rs (+17 -1)
📝 core/src/lib.rs (+1 -0)
📝 core/src/proxytunnel.rs (+96 -35)
📝 core/tests/connect.rs (+1 -0)

📄 Description

~~Adding a git dependency of a hyper_proxy version with tokio 1.0 support. It is not yet merged, and as far as I see there was no reaction of the maintainer: tafia/hyper-proxy#18.~~
Using proxytunnel for apresolve to restore the proxy support.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/583 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 1/26/2021 **Status:** ✅ Merged **Merged:** 2/10/2021 **Merged by:** [@ashthespy](https://github.com/ashthespy) **Base:** `tokio_migration` ← **Head:** `tokio_migration_proxy` --- ### 📝 Commits (5) - [`07514c9`](https://github.com/librespot-org/librespot/commit/07514c9dcca59bd13b149cd19a276fa27c6d6986) Add proxy support to apresolve - [`c97fdeb`](https://github.com/librespot-org/librespot/commit/c97fdeb3b4424c360db4d858bebd6cdc04bc2ac7) Replaced .fold(0, add) by .sum() - [`a45fe85`](https://github.com/librespot-org/librespot/commit/a45fe85c27512b9d1a25b191731dc90103905f62) Enable logging in test - [`c1d62d7`](https://github.com/librespot-org/librespot/commit/c1d62d72a7bd12f757d7d5b09b02b2c2387eda38) Fixed ProxyTunnel - [`bb44b99`](https://github.com/librespot-org/librespot/commit/bb44b99c92f16c2770651e75647a3e19cad8b77a) Use proxytunnel in apresolve ### 📊 Changes **8 files changed** (+190 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+62 -0) 📝 `audio/src/range_set.rs` (+1 -1) 📝 `core/Cargo.toml` (+2 -0) 📝 `core/src/apresolve.rs` (+10 -18) 📝 `core/src/connection/mod.rs` (+17 -1) 📝 `core/src/lib.rs` (+1 -0) 📝 `core/src/proxytunnel.rs` (+96 -35) 📝 `core/tests/connect.rs` (+1 -0) </details> ### 📄 Description ~~Adding a git dependency of a hyper_proxy version with tokio 1.0 support. It is not yet merged, and as far as I see there was no reaction of the maintainer: tafia/hyper-proxy#18.~~ Using proxytunnel for apresolve to restore the proxy support. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#982

No description provided.

Rows
Columns