[PR #560] [CLOSED] passthrough-v2 #972

New issue

Closed

opened 2026-02-27 20:00:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/560
Author: @philippe44
Created: 1/4/2021
Status: ❌ Closed

Base: dev ← Head: passthrough-v2

📝 Commits (2)

1ea5da4 reset commit after squash error
8a3e85d no need of license file

📊 Changes

9 files changed (+411 additions, -70 deletions)

View changed files

📝 .gitignore (+2 -1)
📝 audio/Cargo.toml (+1 -0)
📝 audio/src/lewton_decoder.rs (+15 -14)
📝 audio/src/lib.rs (+37 -2)
📝 audio/src/libvorbis_decoder.rs (+16 -15)
➕ audio/src/passthrough_decoder.rs (+279 -0)
📝 playback/src/config.rs (+2 -0)
📝 playback/src/player.rs (+51 -38)
📝 src/main.rs (+8 -0)

📄 Description

This is an updated version of https://github.com/librespot-org/librespot/pull/327. It adds, per maintainer's request, seek for the passthrough option so that there is no feature difference with a normal decoder, except position which of course does not make sense here.

I had to add a tiny modification to https://github.com/RustAudio/ogg so that I can have access to a mutable inner object. I've submitted a PR but meanwhile, I've added a full version of that modified PacketWriter in case @est31 does not accept it. If he does, we can simply remove the file and the "mod".

This is my first real experience with Rust, so pardon some naive implementation. I hope you'll accept this as it will help the Spotty project for LMS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/560 **Author:** [@philippe44](https://github.com/philippe44) **Created:** 1/4/2021 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `passthrough-v2` --- ### 📝 Commits (2) - [`1ea5da4`](https://github.com/librespot-org/librespot/commit/1ea5da49599ecb63750d2c1bae9a0eec505b0bd2) reset commit after squash error - [`8a3e85d`](https://github.com/librespot-org/librespot/commit/8a3e85d3e0d104e946fa01c7fd4e02049e8e948e) no need of license file ### 📊 Changes **9 files changed** (+411 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) 📝 `audio/Cargo.toml` (+1 -0) 📝 `audio/src/lewton_decoder.rs` (+15 -14) 📝 `audio/src/lib.rs` (+37 -2) 📝 `audio/src/libvorbis_decoder.rs` (+16 -15) ➕ `audio/src/passthrough_decoder.rs` (+279 -0) 📝 `playback/src/config.rs` (+2 -0) 📝 `playback/src/player.rs` (+51 -38) 📝 `src/main.rs` (+8 -0) </details> ### 📄 Description This is an updated version of https://github.com/librespot-org/librespot/pull/327. It adds, per maintainer's request, seek for the passthrough option so that there is no feature difference with a normal decoder, except position which of course does not make sense here. I had to add a tiny modification to https://github.com/RustAudio/ogg so that I can have access to a mutable inner object. I've submitted a PR but meanwhile, I've added a full version of that modified PacketWriter in case @est31 does not accept it. If he does, we can simply remove the file and the "mod". This is my first real experience with Rust, so pardon some naive implementation. I hope you'll accept this as it will help the Spotty project for LMS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:39 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:32 +03:00

[PR #1026] [MERGED] Blacklist ap-gew4 access point #1197

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#972

No description provided.

Rows
Columns